Skip to content

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Oct 31, 2025

No description provided.

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Akrelion45
Copy link
Contributor

Out of curiosity, I randomly looked at that pull request and even tho English is not my native language i am quite sure the Prompt.md file is missing a word after or before the word currently.
Right now the Prompt.md file reads like that:

"Can you give a summary of what you are currently and the remaining tasks."

}

fn build_compacted_history_with_limit(
mut history: Vec<ResponseItem>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pass conversation history struct?

Copy link
Collaborator Author

@jif-oai jif-oai Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this in a dedicated PR if ok for you :)

@pakrym-oai pakrym-oai merged commit 611e00c into main Oct 31, 2025
25 checks passed
@pakrym-oai pakrym-oai deleted the jif/compactor-2 branch October 31, 2025 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants