-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat: compactor 2 #6027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compactor 2 #6027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Out of curiosity, I randomly looked at that pull request and even tho English is not my native language i am quite sure the Prompt.md file is missing a word after or before the word currently. "Can you give a summary of what you are currently and the remaining tasks." |
| } | ||
|
|
||
| fn build_compacted_history_with_limit( | ||
| mut history: Vec<ResponseItem>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pass conversation history struct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this in a dedicated PR if ok for you :)
# Conflicts: # codex-rs/core/tests/suite/compact.rs
No description provided.