-
Notifications
You must be signed in to change notification settings - Fork 6.2k
fix(windows-path): preserve PATH order; include core env vars #5579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+20
−0
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
eaf1fdf
[fix][windows-path]: preserve PATH order; include core env vars
cpjet64 12ad730
[fix][windows-env]: add Path alias and common shell vars
cpjet64 2fcff53
[chore][lint]: avoid unused_mut on non-Windows; drop redundant clone
cpjet64 e2d234f
[fix][windows-path]: mirror Path <-> PATH consistently
cpjet64 f9787a3
Merge branch 'main' into feat/winpath-pathex
cpjet64 b5eba7c
Merge branch 'main' into feat/winpath-pathex
cpjet64 185cff5
Merge branch 'main' into feat/winpath-pathex
cpjet64 9266740
Merge branch 'main' into feat/winpath-pathex
cpjet64 5a2b5db
Merge branch 'main' into feat/winpath-pathex
cpjet64 e7a1f68
Merge branch 'main' into feat/winpath-pathex
cpjet64 28c5630
Merge branch 'main' into feat/winpath-pathex
cpjet64 ad54e6b
Merge branch 'main' into feat/winpath-pathex
cpjet64 655fdb7
Merge branch 'main' into feat/winpath-pathex
cpjet64 9a08f38
Merge branch 'main' into feat/winpath-pathex
cpjet64 7fd616e
[fix][windows-env]: scope PR 5579 to DEFAULT_ENV_VARS only\n\nContext…
cpjet64 a660432
Merge branch 'main' into feat/winpath-pathex
cpjet64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpjet64 if we separate these changes, i'm happy to stamp the
DEFAULT_ENV_VARSchange and merge itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dylan-hurd-oai Happy to do so but was hoping it would pass since my next PR for this issue is virtual shells like Python venv and such and the non-PATH fix is the foundation.
I will make this PR into a dedicated path fix in the meantime.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to switching to appending here, but the impacts of the path change are just more subtle, and might impact the success rate of
apply_patchcalls. Adding env vars to unblock better MCP support on windows feels much lower risk, so let's get that improvement in and we can focus on this PATH change here.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dylan-hurd-oai Understood and I agree the env var change is definitely more low risk because I didn't consider the apply-patch impact in that manner. I'll split them now and get you a new commit in a few minutes! Later I'll dig more into apply_patch to make sure before I push a new PR for it. Thanks for that!