Fix apply_patch cwd handling and add regression test #5484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
Related: #5486. |
Contributor
Author
|
@codex resolve the conflicts |
Contributor
|
Note To use Codex here, create an environment for this repo. |
Collaborator
|
It looks like this PR is stale. If you're still interested in this change, could you please resolve the merge conflicts and make sure that lint checks and test pass locally? Thanks! |
youta7
added a commit
to youta7/ta-codex
that referenced
this pull request
Nov 10, 2025
Collaborator
|
Closing because contributor hasn't responded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5483.
Fixed
apply_patchso the runtime inherits the verifier’s resolved cwd, preventing writes from landing in the primary worktree.Added a regression test that drives a shell cd +
apply_patchflow to lock the behavior in.