feat: add text cleared with ctrl+c to the history so it can be recovered with up arrow #5470
+65
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaviSoto
commented
Oct 21, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
JaviSoto
force-pushed
the
dev/javi/undo-clear-prompt
branch
from
c12b093 to
bd2345d
Compare
JaviSoto
changed the title
gpeal
reviewed
Oct 21, 2025
gpeal
approved these changes
Oct 21, 2025
| if let Some(text) = replace_text { | ||
| self.textarea.set_text(&text); | ||
| self.textarea.set_cursor(0); | ||
| self.set_text_content(text); |
Collaborator
There was a problem hiding this comment.
I assume this was intentional right?
Contributor
Author
There was a problem hiding this comment.
Yeah, but also not required, not sure if there was a reason why we were doing that manually and not doing the rest of things that set_text_content does
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codex-ctrl-c-up-arrow.mov