-
Notifications
You must be signed in to change notification settings - Fork 6.2k
[app-server] model/list API #5382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+488
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a71f4cb to
816e596
Compare
816e596 to
c8073f5
Compare
pakrym-oai
reviewed
Oct 21, 2025
pakrym-oai
reviewed
Oct 21, 2025
pakrym-oai
reviewed
Oct 21, 2025
pakrym-oai
reviewed
Oct 21, 2025
Collaborator
pakrym-oai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks fine but I'm not sure about the data source. This would be the third place we define model lists in Codex (+model_info, +TUI selector).
Contributor
Author
|
@pakrym-oai good call, let me unify things with |
ee5427f to
3b5ac90
Compare
3b5ac90 to
6eedaee
Compare
463881d to
0a83caa
Compare
pakrym-oai
approved these changes
Oct 21, 2025
474747a to
2ffc520
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
model/listpaginated API that returns the list of models supported by Codex.