Skip to content

Conversation

@owenlin0
Copy link
Contributor

@owenlin0 owenlin0 commented Oct 20, 2025

Adds a model/list paginated API that returns the list of models supported by Codex.

@owenlin0 owenlin0 force-pushed the owen/model_list_api branch 5 times, most recently from a71f4cb to 816e596 Compare October 21, 2025 03:36
@owenlin0 owenlin0 changed the title Owen/model list api [app-server] model/list API Oct 21, 2025
@owenlin0 owenlin0 force-pushed the owen/model_list_api branch from 816e596 to c8073f5 Compare October 21, 2025 03:39
@owenlin0 owenlin0 marked this pull request as ready for review October 21, 2025 03:40
Copy link
Collaborator

@pakrym-oai pakrym-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine but I'm not sure about the data source. This would be the third place we define model lists in Codex (+model_info, +TUI selector).

@owenlin0
Copy link
Contributor Author

owenlin0 commented Oct 21, 2025

@pakrym-oai good call, let me unify things with model_presets.rs in common/ as the source of truth

@owenlin0 owenlin0 force-pushed the owen/model_list_api branch from 3b5ac90 to 6eedaee Compare October 21, 2025 16:56
@owenlin0 owenlin0 force-pushed the owen/model_list_api branch from 463881d to 0a83caa Compare October 21, 2025 17:36
@owenlin0 owenlin0 force-pushed the owen/model_list_api branch from 474747a to 2ffc520 Compare October 21, 2025 17:57
@owenlin0 owenlin0 merged commit 26f3149 into main Oct 21, 2025
20 checks passed
@owenlin0 owenlin0 deleted the owen/model_list_api branch October 21, 2025 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants