[MCP] Prefix MCP tools names with mcp__
#5309
Conversation
| @@ -1,4 +1,5 @@ | |||
| /target/ | |||
| /target-*/ | |||
There was a problem hiding this comment.
Not technically related to this PR but I added "rust-analyzer.cargo.targetDir": "target-ide" to my vs code settings.json so terminal builds won't block on IDE updates after edits.
| "{}{}{}", | ||
| tool.server_name, MCP_TOOL_NAME_DELIMITER, tool.tool_name | ||
| "mcp{}{}{}{}", | ||
| MCP_TOOL_NAME_DELIMITER, tool.server_name, MCP_TOOL_NAME_DELIMITER, tool.tool_name |
There was a problem hiding this comment.
Note the longer we make the tool name, the more likely we are to exceed MAX_TOOL_NAME_LENGTH and then we have to use the SHA-1 of the tool name instead, which is more opaque.
Is this worth it? And why does it matter whether a tool comes from an MCP or not? Is this for the agent or users?
There was a problem hiding this comment.
It matters because users often references things as "notion mcp" etc in their prompt and there is also latent mcp knowledge in the model so the context is useful. There are numerous GitHub issues that Codex doesn't use mcp tools as well/often as other agents.
There was a problem hiding this comment.
OK, let's give it a shot, then...
This should make it more clear that specific tools come from MCP servers.
#4806 requested that we add the server name but we already do that.
Fixes #4806