-
Notifications
You must be signed in to change notification settings - Fork 6.2k
fix(tui): Update WSL instructions #5307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,11 +20,24 @@ use crate::onboarding::onboarding_screen::StepStateProvider; | |
| use super::onboarding_screen::StepState; | ||
|
|
||
| pub(crate) const WSL_INSTRUCTIONS: &str = r"Install WSL2 by opening PowerShell as Administrator and running: | ||
|
|
||
| # Install default Linux distribution (Ubuntu is recommended) | ||
| wsl --install | ||
|
|
||
| Instructions for how to install and run Codex in WSL: | ||
| # Restart your computer, then start a shell inside of Windows Subsystem for Linux | ||
| wsl | ||
|
|
||
| # Install Node.js in WSL via nvm | ||
| # Documentation: https://learn.microsoft.com/en-us/windows/dev-environment/javascript/nodejs-on-wsl | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh | bash | ||
|
|
||
| # In a new tab or after exiting and running `wsl` again to install Node.js | ||
| nvm install 22 | ||
dylan-hurd-oai marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| # Install and run Codex in WSL | ||
| npm i -g @openai/codex | ||
dylan-hurd-oai marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| codex | ||
|
|
||
| # Additional details and instructions for how to install and run Codex in WSL: | ||
| https://developers.openai.com/codex/windows"; | ||
|
|
||
| pub(crate) struct WindowsSetupWidget { | ||
|
|
@@ -84,7 +97,7 @@ impl WidgetRef for &WindowsSetupWidget { | |
| let mut lines: Vec<Line> = vec![ | ||
| Line::from(vec![ | ||
| "> ".into(), | ||
| "For best performance, run Codex in Windows Subsystem for Linux (WSL2)".bold(), | ||
| "To use all Codex features, we recommend running Codex in Windows Subsystem for Linux (WSL2)".bold(), | ||
|
Comment on lines
-87
to
+99
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My questions as a user here would be:
It's worth making a note here that links to a website doc about why we're choosing WSL over just running in plain old windows. Likely we want a small blurb about the rationale (support for bash, support for better sandboxing etc.) |
||
| ]), | ||
| Line::from(""), | ||
| ]; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.