Auto compact at ~90% #5292
Auto compact at ~90% #5292
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| _ if slug.starts_with("gpt-5-codex") => Some(ModelInfo::new(258000, 128_000)), | ||
|
|
||
| _ if slug.starts_with("gpt-5") => Some(ModelInfo::new(272_000, 128_000)), | ||
| _ if slug.starts_with("gpt-5") => Some(ModelInfo::new(258000, 128_000)), |
There was a problem hiding this comment.
can we set the context size to real value and infer other?
codex-rs/core/tests/suite/compact.rs
Outdated
| ]); | ||
| let post_auto_compact_turn = sse(vec![ev_completed_with_tokens("r4", 10)]); | ||
|
|
||
| let request_log = mount_sse_sequence( |
There was a problem hiding this comment.
nit: you can mount these one by one and only store mocks of the ones you care about into variables. Avoids needing to index into request_log
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Could you also add either a better title or a description. It's pretty hard to know exactly what we are reviewing atm
codex-rs/core/src/client.rs
Outdated
| } | ||
| } | ||
|
|
||
| const fn apply_context_window_margin(context_window: u64) -> u64 { |
There was a problem hiding this comment.
General comment but let's try to avoid using unsigned int. Even if the value is non-negative, the modulo arithmetic is pretty different
| "gpt-4o-2024-05-13" => Some(ModelInfo::new(128_000, 4_096)), | ||
|
|
||
| // https://platform.openai.com/docs/models/gpt-4o?snapshot=gpt-4o-2024-11-20 | ||
| "gpt-4o-2024-11-20" => Some(ModelInfo::new(128_000, 16_384)), |
There was a problem hiding this comment.
Are we sure all the models support well compaction? Mainly asking for OSS
There was a problem hiding this comment.
They don't have much options anyways they are about to hit the error
Users now hit a window exceeded limit and they usually don't know what to do. This starts auto compact at ~90% of the window.