Skip to content

Conversation

@nornagon-openai
Copy link
Collaborator

Instead of printing characters before booting the app, make the upgrade banner a history cell so it's well-behaved.

Screenshot 2025-10-16 at 4 20 51 PM

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

#![cfg(not(debug_assertions))]
use crate::UpdateAction;
use crate::history_cell::padded_emoji;

P0 Badge Update prompt imports removed UpdateAction symbol

The move of UpdateAction into the updates module removed the pub enum UpdateAction from the crate root, but update_prompt.rs still does use crate::UpdateAction;. Because the crate root no longer re‑exports this type, release builds (where this module is compiled) will fail to compile with an unresolved import. Import the enum from crate::updates::UpdateAction (or re‑export it) so the update prompt continues to build.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@nornagon-openai nornagon-openai enabled auto-merge (squash) October 20, 2025 20:04
Copy link
Collaborator

@joshka-oai joshka-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - added ratatui-macros to shorten the amount of boilerplate Line::from code, used an existing constant for CODEX_CLI_VERSION

@nornagon-openai nornagon-openai enabled auto-merge (squash) October 20, 2025 21:22
@nornagon-openai nornagon-openai merged commit 5815938 into main Oct 20, 2025
19 checks passed
@nornagon-openai nornagon-openai deleted the nornagon/update-cell branch October 20, 2025 21:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants