-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[MCP] Add support for streamable http servers with codex mcp add and replace bearer token handling
#4904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gpeal
commented
Oct 7, 2025
- You can now add streamable http servers via the CLI
- As part of this, I'm also changing the existing bearer_token plain text config field with ane env var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| } | ||
|
|
||
| #[derive(Debug, clap::Args)] | ||
| #[command( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right to me. Chat suggested:
#[derive(Debug, clap::Args)]
pub struct AddMcpTransportArgs {
#[command(flatten)]
#[group(required = true, multiple = false, name = "transport")]
pub stdio: Option<AddMcpStdioArgs>,
#[command(flatten)]
#[group(name = "transport")]
pub streamable_http: Option<AddMcpStreamableHttpArgs>,
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clap is a bit finicky to work with but I wrote unit tests to verify the failure and this change breaks a couple of them.
…tions-with-oauth-store