Skip to content

Conversation

@gpeal
Copy link
Collaborator

@gpeal gpeal commented Oct 7, 2025

  1. You can now add streamable http servers via the CLI
  2. As part of this, I'm also changing the existing bearer_token plain text config field with ane env var
mcp add github --url https://api.githubcopilot.com/mcp/ --bearer-token-env-var=GITHUB_PAT

@gpeal gpeal requested a review from bolinfest October 7, 2025 22:34
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

}

#[derive(Debug, clap::Args)]
#[command(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me. Chat suggested:

#[derive(Debug, clap::Args)]
pub struct AddMcpTransportArgs {
    #[command(flatten)]
    #[group(required = true, multiple = false, name = "transport")]
    pub stdio: Option<AddMcpStdioArgs>,

    #[command(flatten)]
    #[group(name = "transport")]
    pub streamable_http: Option<AddMcpStreamableHttpArgs>,
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clap is a bit finicky to work with but I wrote unit tests to verify the failure and this change breaks a couple of them.

Base automatically changed from gpeal/oauth-store-config to main October 8, 2025 02:39
@gpeal gpeal merged commit a43ae86 into main Oct 8, 2025
20 checks passed
@gpeal gpeal deleted the gpeal/bearer-token-options-with-oauth-store branch October 8, 2025 03:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants