Skip to content

Conversation

@MasterMind7777777
Copy link
Contributor

Summary

  • log and surface clipboard failures instead of silently ignoring them when Ctrl+V pastes an image (paste_image_to_temp_png() now feeds an error history cell)
  • enable arboard’s wayland-data-control feature so native Wayland sessions can deliver image data without XWayland
  • keep the success path unchanged: valid images still attach and show the [image …] placeholder as before

Fixes #4818

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@MasterMind7777777
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 6, 2025
@MasterMind7777777
Copy link
Contributor Author

rebased to new main

@UN-9BOT
Copy link

UN-9BOT commented Oct 20, 2025

up!

@etraut-openai
Copy link
Collaborator

Thanks for the contribution, and apologies for the slow reply. We received many PRs, and we're just now catching up on the backlog.

I took a quick look at your PR. The code change in chatwidget.rs looks reasonable to me, but I don't understand why it includes changes to the Cargo.lock or Cargo.toml files. Please simplify the change.

@etraut-openai
Copy link
Collaborator

codex review

@etraut-openai etraut-openai added the needs-response Additional information is requested label Nov 6, 2025
@MasterMind7777777
Copy link
Contributor Author

Change to Cargo.toml is most important, that is what actually fixes issue that paste image does not work on Wayland, it does not work because dependency(feature) that handles Wayland specific clipboard was not included before.

Change in chatwidget.rs only logs error if something else breaks in image pasting, so in future it would be easier to debug. It does not actually fix anything.

All that needs to be done to be able to do paste image on Wayland is
wayland-data-control feature need to be enabled for lib arboard in Cargo.toml

@etraut-openai etraut-openai removed the needs-response Additional information is requested label Nov 7, 2025
@etraut-openai
Copy link
Collaborator

Thanks for the explanation. I didn't previously understand that wayland-data-control was an optional feature in arboard. Makes sense now.

youta7 added a commit to youta7/ta-codex that referenced this pull request Nov 10, 2025
@etraut-openai etraut-openai merged commit 52e97b9 into openai:main Nov 10, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ctrl+V image paste shows no placeholder on Wayland despite successful clipboard read

4 participants