-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Fix wayland image paste error #4824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wayland image paste error #4824
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
19497d8 to
ce9980d
Compare
|
rebased to new main |
|
up! |
|
Thanks for the contribution, and apologies for the slow reply. We received many PRs, and we're just now catching up on the backlog. I took a quick look at your PR. The code change in |
|
codex review |
|
Change to Cargo.toml is most important, that is what actually fixes issue that paste image does not work on Wayland, it does not work because dependency(feature) that handles Wayland specific clipboard was not included before. Change in chatwidget.rs only logs error if something else breaks in image pasting, so in future it would be easier to debug. It does not actually fix anything. All that needs to be done to be able to do paste image on Wayland is |
|
Thanks for the explanation. I didn't previously understand that |
Co-authored-by: Jeremy Rose <[email protected]>
Summary
Ctrl+Vpastes an image (paste_image_to_temp_png()now feeds an error history cell)arboard’swayland-data-controlfeature so native Wayland sessions can deliver image data without XWayland[image …]placeholder as beforeFixes #4818