test: run app-server integration tests with Wine exec#29491
Conversation
2a22e96 to
6f71f29
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d72959ae2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3cf29d3a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Why
We already support running codex_core integration tests against an exec-server running under Wine, we should extend that support to app-server integration tests.
What
wine-execapp-server integration tests auto-generate a remote-only environments.toml and inject its Windows-native cwd into experimental thread starts when possible.environments.tomland inject its target-native cwd where the protocol supports itCaveats
The approach I've taken here is trying to balance a couple of goals:
(1) argues for making the wiring as implicit/automatic as possible, but (2) means we can't automatically wire it up for literally every test.
Validation
Note that while this patch skips ~most app-server integration tests there are a few that definitely pass and use the exec-server (cmd+f "cwd" in this gist):
command_execution_notifications_include_process_idthread_resume_replays_pending_command_execution_request_approvalturn_start_updates_sandbox_and_cwd_between_turns_v2