Skip to content

test: run app-server integration tests with Wine exec#29491

Open
anp-oai wants to merge 10 commits into
mainfrom
codex/app-server-wine-exec-tests
Open

test: run app-server integration tests with Wine exec#29491
anp-oai wants to merge 10 commits into
mainfrom
codex/app-server-wine-exec-tests

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Why

We already support running codex_core integration tests against an exec-server running under Wine, we should extend that support to app-server integration tests.

What

wine-exec app-server integration tests auto-generate a remote-only environments.toml and inject its Windows-native cwd into experimental thread starts when possible.

  • add Wine execution-environment support to the app-server test harness
  • register the selected remote executor through generated environments.toml and inject its target-native cwd where the protocol supports it
  • skip unsupported cross-OS and local-only cases with follow-up TODOs, and cover the harness itself under remote runners

Caveats

The approach I've taken here is trying to balance a couple of goals:

  1. getting as many existing and new tests to run against a windows exec-server by default
  2. allowing app-server integration tests to explicitly test against particular environment setups

(1) argues for making the wiring as implicit/automatic as possible, but (2) means we can't automatically wire it up for literally every test.

Validation

Note that while this patch skips ~most app-server integration tests there are a few that definitely pass and use the exec-server (cmd+f "cwd" in this gist):

  • command_execution_notifications_include_process_id
  • thread_resume_replays_pending_command_execution_request_approval
  • turn_start_updates_sandbox_and_cwd_between_turns_v2

@anp-oai anp-oai force-pushed the codex/app-server-wine-exec-tests branch from 2a22e96 to 6f71f29 Compare June 22, 2026 22:57
@anp-oai anp-oai marked this pull request as ready for review June 22, 2026 23:38
@anp-oai anp-oai requested a review from a team as a code owner June 22, 2026 23:38
@anp-oai

anp-oai commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d72959ae2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/tests/common/Cargo.toml
Comment thread codex-rs/app-server/tests/common/test_app_server.rs
Comment thread codex-rs/app-server/BUILD.bazel
@anp-oai

anp-oai commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@anp-oai

anp-oai commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3cf29d3a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/BUILD.bazel
Comment thread codex-rs/app-server/tests/common/test_app_server.rs
Comment thread codex-rs/app-server/tests/common/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant