Skip to content

Add indexed web search mode#28489

Merged
winston-openai merged 15 commits into
mainfrom
dev/winston/semi-offline-web-search-mode
Jun 19, 2026
Merged

Add indexed web search mode#28489
winston-openai merged 15 commits into
mainfrom
dev/winston/semi-offline-web-search-mode

Conversation

@winston-openai

@winston-openai winston-openai commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add web_search = "indexed" alongside disabled, cached, and live.
  • Use that same resolved mode for both hosted and standalone web search.
  • For hosted search, send index_gated_web_access: true with external web access enabled only when indexed is selected.
  • For standalone search, preserve the existing boolean wire values for existing modes (cached maps to false and live to true) and send "indexed" only for indexed; disabled keeps the tool unavailable.
  • Carry the mode through managed configuration requirements and generated schemas.

Why

Indexed search provides a middle ground between cached-only search and unrestricted live page fetching. Search queries can remain live while direct page fetches are limited to URLs admitted by the server.

The existing web_search setting remains the single source of truth, so hosted and standalone executors cannot drift into different access modes. Without an explicit indexed selection, the existing model-visible tool and request shapes are unchanged.

web_search = "indexed"

[features]
standalone_web_search = true

Validation

  • just fmt
  • just test -p codex-api (126 passed)
  • just test -p codex-web-search-extension (7 passed)
  • just test -p codex-core code_mode_can_call_indexed_standalone_web_search (1 passed)
  • Focused configuration, hosted request, standalone request, and managed-requirement coverage is included in the PR; remaining suites run in CI.

The full workspace test suite was not run locally.

@winston-openai winston-openai changed the title Add semi-offline web search mode Add index-gated web search mode Jun 16, 2026
@winston-openai winston-openai marked this pull request as ready for review June 17, 2026 20:16
@winston-openai winston-openai requested a review from a team as a code owner June 17, 2026 20:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba2f89589b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/core/src/config/mod.rs Outdated
Comment thread codex-rs/ext/web-search/src/extension.rs Outdated

@jgershen-oai jgershen-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest question is on backward compatibility -- can we ensure there are no model-visible changes without explicitly choosing the new mode?

Comment thread codex-rs/ext/web-search/src/extension.rs Outdated
Comment thread codex-rs/core/tests/suite/code_mode.rs Outdated
Comment thread codex-rs/config/src/config_requirements.rs Outdated
@winston-openai winston-openai changed the title Add index-gated web search mode Add indexed web search mode Jun 18, 2026
@winston-openai winston-openai merged commit 3a2712e into main Jun 19, 2026
31 checks passed
@winston-openai winston-openai deleted the dev/winston/semi-offline-web-search-mode branch June 19, 2026 12:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants