Add indexed web search mode#28489
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba2f89589b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jgershen-oai
left a comment
Collaborator
There was a problem hiding this comment.
My biggest question is on backward compatibility -- can we ensure there are no model-visible changes without explicitly choosing the new mode?
sayan-oai
reviewed
Jun 18, 2026
sayan-oai
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web_search = "indexed"alongsidedisabled,cached, andlive.index_gated_web_access: truewith external web access enabled only whenindexedis selected.cachedmaps tofalseandlivetotrue) and send"indexed"only forindexed;disabledkeeps the tool unavailable.Why
Indexed search provides a middle ground between cached-only search and unrestricted live page fetching. Search queries can remain live while direct page fetches are limited to URLs admitted by the server.
The existing
web_searchsetting remains the single source of truth, so hosted and standalone executors cannot drift into different access modes. Without an explicitindexedselection, the existing model-visible tool and request shapes are unchanged.Validation
just fmtjust test -p codex-api(126 passed)just test -p codex-web-search-extension(7 passed)just test -p codex-core code_mode_can_call_indexed_standalone_web_search(1 passed)The full workspace test suite was not run locally.