Skip to content

fix: fix clippy issue caught by cargo but not bazel#16345

Merged
bolinfest merged 1 commit intomainfrom
pr16345
Mar 31, 2026
Merged

fix: fix clippy issue caught by cargo but not bazel#16345
bolinfest merged 1 commit intomainfrom
pr16345

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Mar 31, 2026

I noticed that https://github.com/openai/codex/actions/workflows/rust-ci-full.yml started failing on my own PR, #16288, even though CI was green when I merged it.

Apparently, it introduced a lint violation that was [correctly!] caught by our Cargo-based clippy runner, but not our Bazel-based one.

My next step is to figure out the reason for the delta between the two setups, but I wanted to get us green again quickly, first.

@bolinfest bolinfest requested a review from etraut-openai March 31, 2026 15:47
@bolinfest bolinfest enabled auto-merge (squash) March 31, 2026 15:55
@bolinfest bolinfest merged commit 03b2465 into main Mar 31, 2026
22 checks passed
@bolinfest bolinfest deleted the pr16345 branch March 31, 2026 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants