Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 671b9fb4bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f121c95b60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if active_turn.is_some() { | ||
| return; | ||
| } | ||
| *active_turn = Some(ActiveTurn::default()); |
There was a problem hiding this comment.
Setting active_turn to Some(ActiveTurn::default()) before the new turn is actually spawned creates a false "active" window. During that window, interrupt_task() will run abort_all_tasks(Interrupted) and call maybe_start_turn_for_pending_work() again, while this original call continues. That can start overlapping synthetic turns or restart work after an interrupt.
Useful? React with 👍 / 👎.
1 participant
No description provided.