Route TUI /feedback submission through the app server#16184
Merged
etraut-openai merged 2 commits intomainfrom Mar 31, 2026
Merged
Route TUI /feedback submission through the app server#16184etraut-openai merged 2 commits intomainfrom
/feedback submission through the app server#16184etraut-openai merged 2 commits intomainfrom
Conversation
…ather than having its own (slightly different) logic.
etraut-openai
changed the title
/feedback submission through the app server
etraut-openai
commented
Mar 29, 2026
Contributor
|
@etraut-openai looks good, approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TUI’s
/feedbackflow was still uploading directly through the local feedback crate, which bypassed app-server behavior such as auth-derived feedback tags like chatgpt_user_id and made TUI feedback handling diverge from other clients. It also meant that remove TUI sessions failed to upload the correct feedback logs and session details.Testing: Manually tested
/feedbackflow and confirmed that it didn't regress.