Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous
codex-toolsmigration steps moved the shared schema models, local-host specs, collaboration specs, and related adapters out ofcodex-core, butcore/src/tools/spec.rsstill contained a grab bag of pure utility tool builders. Those specs do not need session state or handler logic; they only describe wire shapes for tools thatcodex-corealready knows how to execute.Moving that remaining low-coupling layer into
codex-toolskeeps the migration moving in meaningful chunks and trims another large block of passive tool-spec construction out ofcodex-corewithout touching the runtime-coupled handlers.What changed
codex-toolsto own the pure spec builders for:exec/waitjs_repl/js_repl_resetlist_mcp_resources,list_mcp_resource_templates, andread_mcp_resourcelist_dirandtest_sync_tool*_tests.rscoverage, keepingsrc/lib.rsexports-onlycore/src/tools/spec.rsto call the extracted builders and deleted the duplicated core-local implementationscore/src/tools/spec_tests.rsso it now lives with the extracted implementation incodex-toolscodex-rs/tools/README.mdso the documented crate boundary matches the new utility-spec surfaceTest plan
CARGO_TARGET_DIR=/tmp/codex-tools-utility-specs cargo test -p codex-toolsCARGO_TARGET_DIR=/tmp/codex-core-utility-specs cargo test -p codex-core --lib tools::spec::just fix -p codex-tools -p codex-corejust argument-comment-lintReferences