Fix project trust config parsing so CLI overrides work#13090
Fix project trust config parsing so CLI overrides work#13090etraut-openai merged 3 commits intomainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 565bd19e35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
| ) -> io::Result<ProjectTrustContext> { | ||
| let config_toml = deserialize_config_toml_with_base(merged_config.clone(), config_base_dir)?; | ||
| let project_trust_config: ProjectTrustConfigToml = { | ||
| let _guard = AbsolutePathBufGuard::new(config_base_dir); |
There was a problem hiding this comment.
This is not very optimal but I see it's everywhere in the code so I'll fix it everywhere later this week
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Fixes #13076
This PR fixes a bug that causes command-line config overrides for MCP subtables to not be merged correctly.
Summary