Skip to content

fix(CI): prevent deprecation warning about punycode#2987

Merged
mergify[bot] merged 1 commit intoopenSUSE:mainfrom
okurz:fix/eslint
Jan 16, 2026
Merged

fix(CI): prevent deprecation warning about punycode#2987
mergify[bot] merged 1 commit intoopenSUSE:mainfrom
okurz:fix/eslint

Conversation

@okurz
Copy link
Member

@okurz okurz commented Jan 15, 2026

No description provided.

@d3flex
Copy link
Contributor

d3flex commented Jan 16, 2026

Q: why do we want to use a not supported module? there should be something else out there, right? So eventually we will have to come back to it. So no problem to accept the change but wouldnt be better to file a ticket and find a more long term solution?

@okurz
Copy link
Member Author

okurz commented Jan 16, 2026

Q: why do we want to use a not supported module?

Which module is not supported?

@d3flex
Copy link
Contributor

d3flex commented Jan 16, 2026

Q: why do we want to use a not supported module?

Which module is not supported?

I will rephrase. why do we want to use a deprecated module? - https://nodejs.org/api/punycode.html#punycode_punycode

@okurz
Copy link
Member Author

okurz commented Jan 16, 2026

Q: why do we want to use a not supported module?

Which module is not supported?

I will rephrase. why do we want to use a deprecated module? - https://nodejs.org/api/punycode.html#punycode_punycode

The whole repository of qem-dashboard does not reference punycode anywhere so we don't directly use it or rely on it. It's a transient dependency that we don't really care about. You can also just read my commit as "Bump version of actions/setup-node to v6.2.0" if that helps

@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2026

This pull request, with head sha b883423def18a22d2c65ce603bf1c8e3dbc122c9, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha b883423def18a22d2c65ce603bf1c8e3dbc122c9 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch fix/eslint, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit b883423 into openSUSE:main Jan 16, 2026
5 checks passed
@perlpunk
Copy link
Contributor

@d3flex for context, this is about actions/setup-node#1449

@okurz okurz deleted the fix/eslint branch January 16, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants