Skip to content

Modify 'git-obs file maintainership migrate' to filter out empty entries, ident by 2 and sort entries#2126

Merged
dmach merged 3 commits into
openSUSE:masterfrom
dmach:fix/maintainership-cleanup
Apr 30, 2026
Merged

Modify 'git-obs file maintainership migrate' to filter out empty entries, ident by 2 and sort entries#2126
dmach merged 3 commits into
openSUSE:masterfrom
dmach:fix/maintainership-cleanup

Conversation

@dmach
Copy link
Copy Markdown
Contributor

@dmach dmach commented Apr 29, 2026

No description provided.

@dmach dmach changed the title Fix/maintainership cleanup Modify 'git-obs file maintainership migrate' to filter out empty entries, ident by 2 and sort entries Apr 29, 2026
@hramrach
Copy link
Copy Markdown
Contributor

I don't really understand the need for those parameters.

In what protocol is a null value required?

In what case are unsorted keys required?

Adding those options makes the code more complex, and I don't see when those options would be needed.

@hramrach
Copy link
Copy Markdown
Contributor

Also #2118 now passes tests while this still does break some.

@dmach dmach force-pushed the fix/maintainership-cleanup branch from dc1054b to 5c240dc Compare April 30, 2026 06:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.94%. Comparing base (fb9ba30) to head (5c240dc).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
+ Coverage   33.90%   33.94%   +0.03%     
==========================================
  Files         196      199       +3     
  Lines       26988    27035      +47     
==========================================
+ Hits         9151     9177      +26     
- Misses      17837    17858      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@ncounter ncounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmach dmach merged commit ee6c93c into openSUSE:master Apr 30, 2026
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants