-
Notifications
You must be signed in to change notification settings - Fork 54
Advanced backend configuration via JSON #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced backend configuration via JSON #569
Conversation
|
I updated the CI with further ADIOS2 tests in #568. |
include/openPMD/Series.hpp
Outdated
| * | ||
| * @param name String of the pattern for file names. Must include iteration regex <CODE>\%T</CODE> for fileBased data. | ||
| * @param name String of the pattern for file names. Must include | ||
| * iteration regex <CODE>\%T</CODE> for fileBased data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe align this to beginning of description?
include/openPMD/Series.hpp
Outdated
|
|
||
| OPENPMD_private: | ||
| struct ParsedInput; | ||
| OPENPMD_private : struct ParsedInput; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this syntax confuses me, probably an auto-formatting issue?
5dab8da to
2765f82
Compare
|
@franzpoeschel I rebased this for you. |
|
We should decide if we want to make I will commit a patch for the latter for now, but it's not pretty. |
|
I implemented the selection of the preferred Lines 868 to 887 in 731a407
We can also overwrite that by a runtime option, like the other options you added. Adding control to HDF5 for collective/independent IO, via |
|
ping @franzpoeschel any thoughts on this? :) |
da5ab03 to
a98a695
Compare
|
I'm fine with controlling the |
Agreed, the env var was a quick hack of mine but I want users to be able to control it via an option, which is more friendly and which is why I try to merge this PR soon :)
Argh, too bad. Can you potentially finish the ADIOS impl. with it and I take a look at the other backends?
Excellent, agreed. Will do that in an independent PR then (#587). Edit: branch updated and rebased so you can finish the ADIOS2 controls. |
a98a695 to
9d600db
Compare
9d600db to
c0aad60
Compare
|
ping @franzpoeschel finishing this one would also be really nice, please :) |
|
My plan is to have topic-streaming go on top of this one, so this is part of the endeavours ;) |
c0aad60 to
a98a695
Compare
|
Sounds great, I already made the JSON backend required so you just need to rebase to continue. |
a98a695 to
8be39c7
Compare
|
@franzpoeschel just since I need this more urgently for HDF5 option control and compression support: when do you think you can continue to work on this? |
Remove traces of openPMD_HAVE_JSON Improve JSON highlighting in documentation Formatting improvements in documentation Includes reordering Documentation
Also remove some outdated todos.
faf4a66 to
422143b
Compare
| Configuration Structure per Backend | ||
| ----------------------------------- | ||
|
|
||
| ADIOS2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, and I think this can be a follow-up PR as well, I think these backend-specific options should go into the respective backend docs page (where we also document the current environment vars).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franzpoeschel please try to split this up in a follow-up PR, we already have backend-specific docs where this should go :)
e0f324f to
c20eb42
Compare
Co-Authored-By: Axel Huebl <[email protected]>
c20eb42 to
00768b9
Compare
This PR adds backend-specific configuration options. Close #150. The configuration is passed as an optional string parameter in JSON format to the constructor of
openPMD::Series.The top-level JSON maps backends to the corresponding backend's configuration. This allows to configure several backends at once.
At the moment, only the ADIOS2 backend has been made aware of this. A possible configuration looks like this:
TODO:
docs/source/backends/adios2.rstProbably follow-up for a later PR: