-
Notifications
You must be signed in to change notification settings - Fork 53
Non-spatial meshes #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-spatial meshes #1534
Conversation
|
This PR should be split into two parts at some point:
The first part might then also be relevant for other PRs where breaking changes are introduced (e.g. #1493 use of abbreviated attributes by default in JSON backend) EDIT: Done #1551 |
7a1760a to
a6a8547
Compare
a6a8547 to
26b21aa
Compare
26b21aa to
3948173
Compare
7534cb8 to
6d7513b
Compare
6d7513b to
a244159
Compare
47c9d00 to
a9019f7
Compare
a9019f7 to
ffbd45a
Compare
d184a23 to
6045e89
Compare
6045e89 to
fc9862b
Compare
da28b8c to
12ed9bd
Compare
12ed9bd to
bbc5c10
Compare
bbc5c10 to
2ff3cb5
Compare
f034d20 to
3b4255b
Compare
3b4255b to
a57bc66
Compare
a57bc66 to
9965f6c
Compare
1e6bb68 to
227cb94
Compare
4fbdd31 to
92ef3ca
Compare
We cannot upgrade users silently in this place
for more information, see https://pre-commit.ci
7d493a4 to
44decb6
Compare
|
I took a look over the PR and it seems okay to me. The interface fits for the binningPlugin use case. However the review isnt very thorough as I am unfamiliar with most of the code base and I don't know enough to follow some workflows. |
|
A small comment is that in the binningPlugin in PIConGPU i was using |
|
Thank you for reviewing, Tapish!
Can you point me to where exactly you mean? Within the context of this PR, Beyond that, we have always had two representations for Units: With this PR, |
|
Yes, you are right. It was my misunderstanding. Looks good! |
Implements openPMD/openPMD-standard#193
TODO: