Skip to content

Conversation

@franzpoeschel
Copy link
Contributor

This PR:

  1. Removes ParseError from Error.hpp. It's a leftover from Parsing logic: fail gracefully on unexpected input #1237 that I ended up not using.
  2. Uses error::OperationUnsupportedInBackend instead of unsupported_data_error and removes unsupported_data_error (only used in ADIOS1 implementation)
  3. Puts no_such_attribute_error into Error.hpp, moves it into the error namespace as error::NoSuchAttribute, creates a compatibility alias for it and creates a Python binding for it.

Fix #1354.

@ax3l ax3l self-assigned this Jan 5, 2023
@ax3l ax3l self-requested a review January 5, 2023 16:10
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! :)

@ax3l ax3l merged commit 351d751 into openPMD:dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python bindings for all custom exception types

2 participants