Skip to content

Fix premature flushing (performance bug) #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2022
Merged

Fix premature flushing (performance bug) #1264

merged 3 commits into from
May 6, 2022

Conversation

@franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented May 2, 2022 •
edited
Loading

Fix #1263

TODO:

  • Fix premature flushes in context of scalar components
  • Document the new IO task

@franzpoeschel franzpoeschel force-pushed the fix-premature-flushing branch 3 times, most recently from 72d18f5 to 8f93a4f Compare May 3, 2022 14:17
@ax3l
Copy link
Member

ax3l commented May 3, 2022

ready to rebase :)

@franzpoeschel franzpoeschel force-pushed the fix-premature-flushing branch from 8f93a4f to e7bc391 Compare May 4, 2022 08:16
@ax3l ax3l merged commit 1d32922 into openPMD:dev May 6, 2022
@ax3l ax3l self-assigned this May 6, 2022
@ax3l ax3l mentioned this pull request May 6, 2022
Merged
11 tasks
@franzpoeschel
Copy link
Contributor Author

franzpoeschel commented Oct 4, 2022

This PR introduced a subtle bug: In scalar constant record components, some superfluous attributes are created

  uint64_t  /data/1/particles/e/positionOffset/positionOffset/shape  attr
  int32_t   /data/1/particles/e/positionOffset/positionOffset/value  attr
  uint64_t  /data/1/particles/e/positionOffset/shape                 attr
  float     /data/1/particles/e/positionOffset/timeOffset            attr
  double    /data/1/particles/e/positionOffset/unitDimension         attr
  double    /data/1/particles/e/positionOffset/unitSI                attr
  int32_t   /data/1/particles/e/positionOffset/value                 attr

@franzpoeschel franzpoeschel mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels

bug internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Performance bug: Premature IO flushing when using scalar components

2 participants

@franzpoeschel @ax3l