Skip to content

Conversation

@franzpoeschel
Copy link
Contributor

Fix #1257

@ax3l
Copy link
Member

ax3l commented May 2, 2022

Thanks a lot!

Do you also want to update the "bp5" locations in src/IO/ADIOS/ADIOS2IOHandler.cpp?

I also looked at src/config.cpp for openPMD::getFileExtensions() - but there we only list bp right now.

@franzpoeschel
Copy link
Contributor Author

We don't currently check for available engines in the ADIOS2 backend at all (on Windows, there's no SST, but we don't check for that)
Maybe we should do it? But if so, then that should maybe go into a different PR. Currently, there will be an ADIOS2 error if selecting an unknown engine (e.g. "This version didnt compile with…" or "Unknown engine type …")

I also looked at src/config.cpp for openPMD::getFileExtensions() - but there we only list bp right now.

Good point, this is a Todo for #1218

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thank you :)

@ax3l ax3l merged commit feefb0e into openPMD:dev May 3, 2022
@ax3l ax3l removed this from the 0.14.5 milestone May 25, 2022
@ax3l
Copy link
Member

ax3l commented May 25, 2022

As discussed: BP5 patches will first land in 0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADIOS BP5 Support: Conditional Compile Variant

2 participants