Fixes for BP5 engine #1215
Fixes for BP5 engine #1215
Conversation
franzpoeschel
changed the title
franzpoeschel
force-pushed
the
adios2-bp5-enable-span-api
branch
2 times, most recently
from
c33e761 to
91b438f
Compare
franzpoeschel
force-pushed
the
adios2-bp5-enable-span-api
branch
from
91b438f to
02cffc4
Compare
| if (it != streamingEngines.end()) | ||
| { | ||
| isStreaming = true; | ||
| optimizeAttributesStreaming = |
There was a problem hiding this comment.
We can think about removing this optimization, it becomes irrelevant in variable-based iteration encoding and there is no harm in using that encoding for streaming.
Not relevant for this PR though.
| { | ||
| adios2::Engine &eng = getEngine(); | ||
| /* | ||
| * If streamStatus is Parsing, do NOT open the step. |
There was a problem hiding this comment.
Should have added this comment earlier already, just took the opportunity now
| // return status is stored in m_lastStepStatus | ||
| if (streamStatus != StreamStatus::DuringStep) | ||
| { | ||
| flush( |
There was a problem hiding this comment.
Flushing here was wrong but harmless before. This dormant bug has woken up with this PR, so change it.
| #if openPMD_HAVE_ADIOS2 && \ | ||
| ADIOS2_VERSION_MAJOR * 1000000000 + ADIOS2_VERSION_MINOR * 100000000 + \ | ||
| ADIOS2_VERSION_PATCH * 1000000 + ADIOS2_VERSION_TWEAK >= \ | ||
| 2701001223 |
There was a problem hiding this comment.
Note that our CI does not yet have any ADIOS2 versions that satisfy these conditions
|
Reminder to myself: ReadRandomAccess |
franzpoeschel
force-pushed
the
adios2-bp5-enable-span-api
branch
from
9bbaf87 to
e58ff30
Compare
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
Thank you!
Did I see correctly that we should backport this to 0.14.5?
|
As discussed: targeting BP5 patches for the 0.15.0 release only (no backports to 0.14.*) |
2 participants
Uh oh!
There was an error while loading. Please reload this page.