-
Notifications
You must be signed in to change notification settings - Fork 35
fix: resolve Firebase App Distribution failure in KMP template #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,287 @@ | ||
| { | ||
| "project_info": { | ||
| "project_number": "project_number", | ||
| "firebase_url": "firebase_url", | ||
| "project_id": "project_id", | ||
| "storage_bucket": "storage_bucket" | ||
| "project_number": "728434912738", | ||
| "project_id": "mifos-mobile-apps", | ||
| "storage_bucket": "mifos-mobile-apps.firebasestorage.app" | ||
| }, | ||
| "client": [ | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "mobilesdk_app_id", | ||
| "mobilesdk_app_id": "1:728434912738:android:3902eb3363b0938f1a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "org.mifos" | ||
| "package_name": "cmp.android.app" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simply add the prod/demo flavor's package name will suffice and keep the existing Mifos mobile packages. Usually when you register the new app in Firebase, the |
||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "1:728434912738:android:ecdb5b96f0e735661a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "com.mifos.mifosxdroid" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "1:728434912738:android:53d0930e402622611a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "com.mifos.mifosxdroid.demo" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "1:728434912738:android:d853a78f14af0c381a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "org.mifos.mobile" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "current_key" | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "mobilesdk_app_id", | ||
| "mobilesdk_app_id": "1:728434912738:android:7845cce9777d9cf11a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "org.mifos.demo.debug" | ||
| "package_name": "org.mifos.mobile.demo" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "current_key" | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "mobilesdk_app_id", | ||
| "mobilesdk_app_id": "1:728434912738:android:49282a75468730891a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "org.mifos.demo" | ||
| "package_name": "org.mifos.pisp.android" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "current_key" | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "mobilesdk_app_id", | ||
| "mobilesdk_app_id": "1:728434912738:android:ef7156e455c6a1a41a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "org.mifos.debug" | ||
| "package_name": "org.mifos.pisp.android.debug" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "current_key" | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "1:728434912738:android:0490c291986f0a691a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "org.mifospay" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-d4hshajpu39bq9m5e55s5d2u5hplh5ie.apps.googleusercontent.com", | ||
| "client_type": 1, | ||
| "android_info": { | ||
| "package_name": "org.mifospay", | ||
| "certificate_hash": "d2fd346d362db97e693cfb13424b82bb94b92b56" | ||
| } | ||
| }, | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "1:728434912738:android:48ccd9153349f31e1a1dbb", | ||
| "android_client_info": { | ||
| "package_name": "org.mifospay.demo" | ||
| } | ||
| }, | ||
| "oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-qm031urb7aopd1jofq12u3b8snlj2nel.apps.googleusercontent.com", | ||
| "client_type": 1, | ||
| "android_info": { | ||
| "package_name": "org.mifospay.demo", | ||
| "certificate_hash": "d2fd346d362db97e693cfb13424b82bb94b92b56" | ||
| } | ||
| }, | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [ | ||
| { | ||
| "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com", | ||
| "client_type": 3 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "configuration_version": "1" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ module AndroidConfig | |
| } | ||
|
|
||
| FIREBASE_CONFIG = { | ||
| firebase_prod_app_id: "1:728434912738:android:d853a78f14af0c381a1dbb", | ||
| firebase_prod_app_id: "1:728434912738:android:3902eb3363b0938f1a1dbb", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is sufficient to build and deploy the project. But we've to encode and add the actual google services file on GitHub secrets. Before we had a plan to publish and deploy apps to Playstore and Firebase and but due to some other work we've not registered our app and update this file. |
||
| firebase_demo_app_id: "1:728434912738:android:8392hjksak9032skja", | ||
| firebase_service_creds_file: "secrets/firebaseAppDistributionServiceCredentialsFile.json", | ||
| firebase_groups: "kmp-project-template-testers" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HekmatullahAmin The inclusion of actual credentials was unnecessary. Only the package name is required for it to function correctly. We intentionally avoid exposing sensitive credentials publicly, as the actual file will be overridden during the specific CI run.