Add enum values to deployment.environment.name#3492
Open
Arnav-Bansal wants to merge 6 commits intoopen-telemetry:mainfrom
Open
Add enum values to deployment.environment.name#3492Arnav-Bansal wants to merge 6 commits intoopen-telemetry:mainfrom
Arnav-Bansal wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Arnav Bansal <[email protected]>
Removed trailing comments and empty lines from service.md
trask
reviewed
Mar 2, 2026
3 tasks
kamphaus
reviewed
Mar 5, 2026
| - id: production | ||
| value: "production" | ||
| brief: Production environment | ||
| stability: stable |
Contributor
There was a problem hiding this comment.
Is it right to have stable values inside a development enum?
Should the values be development stability as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
This PR adds 4 enum values (Production, Staging, Test, Development) to deployment.environment.name attribute.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]