Add in declarative config settings as config tables to signals#3432
Draft
thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
Add in declarative config settings as config tables to signals#3432thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
3081519 to
4a2ab26
Compare
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
4a2ab26 to
1582473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
This introduces configuration sections to spans when the defintion contains:
This configuration section describes the settings which can be used to control the inclusion of attributes.
This pr is an alternative to #3424 and removes manually maintained docs and instead go for generated docs.
The big advantage is that this approach makes it explicit which attributes are impacted and ensure that a reader has a single location to look at
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]