Skip to content

Conversation

@ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 4, 2025

Fixes #3171

Related to #3120 and open-telemetry/opentelemetry-collector-contrib#44483

Changes

This PR adds k8s.pod.ip, k8s.pod.hostname, k8s.pod.start_time attributes.
These attributes are in use by the Collector and specifically the k8sattributes processor for quite some time now: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/b21d021babdc94d091da3c2393aeb0638e5349ec/processor/k8sattributesprocessor/internal/kube/client.go#L786-L811

The Collector SIG is working towards stabilising this component and it would be beneficial to have the attributes that it populates defined as Semantic Conventions.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@ChrsMark ChrsMark requested review from a team as code owners December 4, 2025 11:47
@github-actions github-actions bot added enhancement New feature or request area:k8s labels Dec 4, 2025
@ChrsMark ChrsMark self-assigned this Dec 4, 2025
@ChrsMark ChrsMark moved this to In Review in K8s SemConv SIG Dec 4, 2025
@ChrsMark ChrsMark moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Dec 4, 2025
@lmolkova lmolkova moved this from Awaiting codeowners approval to Needs More Approval in Semantic Conventions Triage Dec 4, 2025
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment on timestamp format

@lmolkova lmolkova added this pull request to the merge queue Dec 6, 2025
Merged via the queue into open-telemetry:main with commit 553978a Dec 6, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in K8s SemConv SIG Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:k8s enhancement New feature or request

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

[k8s] Define k8s.pod.hostname, k8s.pod.ip, k8s.pod.start_time as Semantic Conventions

5 participants