Relax collision detection policy to allow collisions between deprecated namespaces and attributes (and vice-versa) #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Dec 2, 2024
jsuereth
approved these changes
Dec 2, 2024
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Looks good, just one minor nit.
added 2 commits
December 2, 2024 13:16
…ed namespaces and attributes ro deprecated attributes and namespaces
lmolkova
force-pushed
the
deprecated-namespace-collision
branch
from
c11ae76 to
4868d6c
Compare
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1624, #1638
Preventing collisions between namespace and attribute name is a protection in case we want to support nested properties in the attributes or add any semantic meaning to namespaces. E.g. having non-deprecated attribute
fooalong with non-deprecated attributefoo.barwould be problematic.It seems fine however to have deprecated
fooalong with non-deprecatedfoo.bar.This PR relaxes the policy and unblocks PRs like #1624 and #1638 (if they are approved).