-
Notifications
You must be signed in to change notification settings - Fork 306
rename some code attributes #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
df9f28f
rename things
SylvainJuge 556dbd4
add changelog
SylvainJuge cc9c646
update schema-next.yaml
SylvainJuge 528affe
fix changelog
SylvainJuge f86eb82
update markdown
SylvainJuge fe2bd7b
keep deprecated attributes for compatibility
SylvainJuge c15674d
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
SylvainJuge 22c0413
update schema-next post 1.29 semconv release
SylvainJuge f27d311
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
SylvainJuge 4262528
Merge branch 'main' into code-rename
f5d4a27
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
SylvainJuge 9303339
rename code.filepath to code.file.path
SylvainJuge feb012a
Merge branch 'main' into code-rename
4fb9d03
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
SylvainJuge 07c6660
add missing attribute in schema next
SylvainJuge 0783448
update references to 'code.function'
SylvainJuge 4ae0d44
update more references to code.filepath
SylvainJuge c108ab2
add warning to not migrate until stable
SylvainJuge dba322e
fix mising markdown ref
SylvainJuge 70b3ed4
try to fix readme again
SylvainJuge 627914d
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
SylvainJuge c523c56
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
SylvainJuge 8e458ac
Apply suggestions from code review
SylvainJuge e75629a
Merge branch 'main' of github.com:open-telemetry/semantic-conventions…
SylvainJuge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: code | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: rename `code.function`, `code.lineno` and `code.column` | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [ 1377, 1599 ] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| `code.function` renamed to `code.function.name` | ||
| `code.lineno` renamed to `code.line.number` | ||
| `code.column` renamed to `code.column.number` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| groups: | ||
| - id: registry.code.deprecated | ||
| type: attribute_group | ||
| display_name: Deprecated Code Attributes | ||
| brief: > | ||
| These deprecated attributes provide context about source code | ||
| attributes: | ||
| - id: code.function | ||
| type: string | ||
| stability: experimental | ||
| deprecated: Replaced by `code.function.name` | ||
| brief: > | ||
| Deprecated, use `code.function.name` instead | ||
| examples: serveRequest | ||
| - id: code.lineno | ||
| type: int | ||
| stability: experimental | ||
| deprecated: Replaced by `code.line.number` | ||
| brief: > | ||
| Deprecated, use `code.line.number` instead | ||
| examples: 42 | ||
| - id: code.column | ||
| type: int | ||
| stability: experimental | ||
| deprecated: Replaced by `code.column.number` | ||
| brief: > | ||
| Deprecated, use `code.column.number` | ||
| examples: 16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.