Skip to content

Conversation

@SylvainJuge
Copy link
Contributor

@SylvainJuge SylvainJuge commented Nov 20, 2024

Relates to #1377

Changes

This PR marks the non-deprecated code.* attributes as release candidate.

Merge requirement checklist

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's mark as release candidate first, we don't have a great way to do that yet, but you can follow pattern used in #1101

@SylvainJuge SylvainJuge changed the title mark code.* attributes as stable mark code.* attributes as release candidate Nov 21, 2024
@lmolkova
Copy link
Member

I support this change.

A few things we should also update:

@SylvainJuge SylvainJuge mentioned this pull request Nov 27, 2024
3 tasks
@SylvainJuge
Copy link
Contributor Author

I have opened #1624 for the naming changes suggestions, it contains a list of all the repositories that would be impacted.

@github-actions github-actions bot added the enhancement New feature or request label Mar 3, 2025
@SylvainJuge
Copy link
Contributor Author

Now that #1624 and #1677 are now merged, we should be able to move this forward and mark the attributes as release-candidate, so I've refreshed the PR and it should now be ready to review.

@SylvainJuge SylvainJuge marked this pull request as ready for review March 3, 2025 13:25
@SylvainJuge SylvainJuge requested a review from a team as a code owner March 3, 2025 13:25
@SylvainJuge SylvainJuge requested review from a team as code owners March 3, 2025 13:25
@jsuereth jsuereth moved this from Untriaged to In Review in Semantic Conventions Triage Mar 3, 2025
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but would like to see @task's proposed changes merged

@github-project-automation github-project-automation bot moved this from In Review to Needs More Approval in Semantic Conventions Triage Mar 4, 2025
@lmolkova lmolkova moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Mar 4, 2025
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we first have a release with code.namespace marked as deprecated?

Otherwise, we are just removing code.namespace and this changelog entry does not make sense: https://github.com/SylvainJuge/semantic-conventions/blob/0acdb7241e968c434d0fe279a6bfd375642d13ce/.chloggen/1646.yaml

@github-project-automation github-project-automation bot moved this from Ready to be Merged to Blocked in Semantic Conventions Triage Mar 5, 2025
@lmolkova
Copy link
Member

lmolkova commented Mar 5, 2025

@pellared it's already deprecated

deprecated: Value should be included in `code.function.name` which is expected to be a fully-qualified name.

this PR only removed the reference to it from the attribute group and didn't change anything about the attribute definition. That's a common practice we follow in semconv and it's not breaking code-gen.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per

That's a common practice we follow in semconv and it's not breaking code-gen.

@github-project-automation github-project-automation bot moved this from Blocked to Needs More Approval in Semantic Conventions Triage Mar 5, 2025
@lmolkova lmolkova merged commit d3bff0d into open-telemetry:main Mar 6, 2025
15 checks passed
@SylvainJuge
Copy link
Contributor Author

SylvainJuge commented Mar 6, 2025

Thanks for merging this !

What are the usual next steps after release candidate promotion ?

My understanding is that it's probably like this, feel free to comment if there are missing pieces:

  • wait for a semconv release (1.31.0) with code.* in RC
  • open another PR to promote to stable
  • wait for another semconv release (1.32.0) with code.* stable
  • start updating usages of code.* semconv to the new stable attributes: maybe this work needs to start when RC attributes are available.

@SylvainJuge SylvainJuge deleted the stable-code branch March 6, 2025 08:46
@pellared
Copy link
Member

pellared commented Mar 6, 2025

start updating usages of code.* semconv to the new stable attributes

Already done in OTel Go:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants