-
Notifications
You must be signed in to change notification settings - Fork 305
mark code.* attributes as release candidate #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
trask
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's mark as release candidate first, we don't have a great way to do that yet, but you can follow pattern used in #1101
|
I support this change. A few things we should also update:
|
|
I have opened #1624 for the naming changes suggestions, it contains a list of all the repositories that would be impacted. |
Co-authored-by: Liudmila Molkova <[email protected]>
jsuereth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but would like to see @task's proposed changes merged
pellared
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we first have a release with code.namespace marked as deprecated?
Otherwise, we are just removing code.namespace and this changelog entry does not make sense: https://github.com/SylvainJuge/semantic-conventions/blob/0acdb7241e968c434d0fe279a6bfd375642d13ce/.chloggen/1646.yaml
|
@pellared it's already deprecated
this PR only removed the reference to it from the attribute group and didn't change anything about the attribute definition. That's a common practice we follow in semconv and it's not breaking code-gen. |
pellared
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per
That's a common practice we follow in semconv and it's not breaking code-gen.
|
Thanks for merging this ! What are the usual next steps after release candidate promotion ? My understanding is that it's probably like this, feel free to comment if there are missing pieces:
|
Already done in OTel Go: |
Relates to #1377
Changes
This PR marks the non-deprecated
code.*attributes as release candidate.Merge requirement checklist
[chore]