[cicd] add initial cicd attributes to registry#1075
[cicd] add initial cicd attributes to registry#1075joaopgrassi merged 49 commits intoopen-telemetry:mainfrom
Conversation
Adjusts the original deployment environment attribute to match proposal.
adrielp
changed the title
|
This pull request comes out of #915. Notably, this comment on the issue. I additionally added the As of the time of writing this comment, this pull request does not address the filling:
Will be having some convo's this week & iterating as necessary. Additionally, I noticed This begs the question, should I separate out each namespace (ie. |
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Thanks for making the changes from our discussion! Looks good.
trisch-me
left a comment
trisch-me
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this huge PR and work, you have put into it.
I just left minor comments, but they are not affecting my approval
BREAKING CHANGE: This also updates the Semantic Conventions of the emitted resource attributes from v1.19.0 to v1.37.0 which involves these breaking changes: - App Service resource detector: `deployment.environment` -> `deployment.environment.name` This changed in semconv v1.27.0 as part of open-telemetry/semantic-conventions#1075 - Semconv v1.35.0 naming convention changes (https://github.com/open-telemetry/semantic-conventions/blob/main/CHANGELOG.md#v1350) resulted in a change in the name of some `cloud.platform` values: - `azure_app_service` -> `azure.app_service` - `azure_vm` -> `azure.vm` - `azure_functions` -> `azure.functions` Refs: open-telemetry#2377
13 participants
Adds proposed CICD common attributes to the registry.
Fixes #915
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]