-
Notifications
You must be signed in to change notification settings - Fork 323
Open
Labels
Description
See open-telemetry/opentelemetry-java-instrumentation#16276 (comment)
In database conventions:
error.typeis the same asrpc.response.status_codewhen operation fails with response- but we mark
rpc.response.status_codeasconditionally_required: If the operation failed and status code is available
It seems to be more interesting when operation didn't fail (some databases return status code without failure). When operation fails, the presence of rpc.response.status_code may indicate that some response was received but the value of it is pretty small and it can be usually deduced from error.type value.
What we can do:
- Consider options for stable DB semconv. I don't think it warrants a breaking change
- Update DB systems that didn't go stable yet
- Revisit this for RPC
- Potentially document a more nuanced guidance in
semantic-conventions/model/error/registry.yaml
Lines 35 to 39 in 084f18e
| If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes), | |
| it's RECOMMENDED to: | |
| - Use a domain-specific attribute | |
| - Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not. |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Need triage
Status
No status