Skip to content

fix(comparison_dashboard): Properly collect engine metrics for the go collector #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakeDern wants to merge 3 commits into from
Open

fix(comparison_dashboard): Properly collect engine metrics for the go collector #2971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54e4c98
c
JakeDern May 14, 2026
9d7f14e
Merge branch 'main' into comparison-dashboard-metrics-traces-report
JakeDern May 14, 2026
9ea5bf6
Merge branch 'main' into comparison-dashboard-metrics-traces-report
JakeDern May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions tools/pipeline_perf_test/test_suites/comparison_dashboard/reports/report_logs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ queries:
FROM component_resource_metrics crm
CROSS JOIN metadata_row
LEFT JOIN component_core_counts ccc ON crm.component_name = ccc.component_name
WHERE crm.component_name IN ('df-engine') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
WHERE crm.component_name IN ('df-engine', 'go-collector') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')

UNION ALL

Expand All @@ -279,23 +279,23 @@ queries:
FROM component_resource_metrics crm
CROSS JOIN metadata_row
LEFT JOIN component_core_counts ccc ON crm.component_name = ccc.component_name
WHERE crm.component_name IN ('df-engine') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
WHERE crm.component_name IN ('df-engine', 'go-collector') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')

UNION ALL

SELECT 'ram_mib_avg' AS name, 'MiB' AS unit, avg_value / 1024 / 1024 AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - RAM (MiB)' AS extra
FROM component_resource_metrics
CROSS JOIN metadata_row
WHERE component_name IN ('df-engine') AND metric_name IN ('container.memory.usage', 'process.memory.usage')
WHERE component_name IN ('df-engine', 'go-collector') AND metric_name IN ('container.memory.usage', 'process.memory.usage')

UNION ALL

SELECT 'ram_mib_max' AS name, 'MiB' AS unit, max_value / 1024 / 1024 AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - RAM (MiB)' AS extra
FROM component_resource_metrics
CROSS JOIN metadata_row
WHERE component_name IN ('df-engine') AND metric_name IN ('container.memory.usage', 'process.memory.usage')
WHERE component_name IN ('df-engine', 'go-collector') AND metric_name IN ('container.memory.usage', 'process.memory.usage')

UNION ALL

Expand Down Expand Up @@ -327,15 +327,15 @@ queries:
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - Network Utilization' AS extra
FROM container_network_rates
CROSS JOIN metadata_row
WHERE metric_name = 'container.network.tx' AND component_name IN ('df-engine')
WHERE metric_name = 'container.network.tx' AND component_name IN ('df-engine', 'go-collector')

UNION ALL

SELECT 'network_rx_bytes_rate_avg' AS name, 'bytes/sec' AS unit, average_rate AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - Network Utilization' AS extra
FROM container_network_rates
CROSS JOIN metadata_row
WHERE metric_name = 'container.network.rx' AND component_name IN ('df-engine');
WHERE metric_name = 'container.network.rx' AND component_name IN ('df-engine', 'go-collector');

- name: Dashboard time-series data
sql: |
Expand All @@ -349,7 +349,7 @@ queries:
CROSS JOIN observation_window ow
LEFT JOIN component_core_counts ccc ON cr.component_name = ccc.component_name
WHERE cr.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
AND cr.component_name IN ('df-engine')
AND cr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -361,7 +361,7 @@ queries:
FROM component_resource_with_values cr
CROSS JOIN observation_window ow
WHERE cr.metric_name IN ('container.memory.usage', 'process.memory.usage')
AND cr.component_name IN ('df-engine')
AND cr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -374,7 +374,7 @@ queries:
JOIN observation_window ow ON nr.timestamp BETWEEN ow.start_ts AND ow.stop_ts
WHERE nr.rate IS NOT NULL
AND nr.metric_name = 'container.network.tx'
AND nr.component_name IN ('df-engine')
AND nr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -387,7 +387,7 @@ queries:
JOIN observation_window ow ON nr.timestamp BETWEEN ow.start_ts AND ow.stop_ts
WHERE nr.rate IS NOT NULL
AND nr.metric_name = 'container.network.rx'
AND nr.component_name IN ('df-engine')
AND nr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand Down
20 changes: 10 additions & 10 deletions tools/pipeline_perf_test/test_suites/comparison_dashboard/reports/report_metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ queries:
FROM component_resource_metrics crm
CROSS JOIN metadata_row
LEFT JOIN component_core_counts ccc ON crm.component_name = ccc.component_name
WHERE crm.component_name IN ('df-engine') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
WHERE crm.component_name IN ('df-engine', 'go-collector') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')

UNION ALL

Expand All @@ -279,23 +279,23 @@ queries:
FROM component_resource_metrics crm
CROSS JOIN metadata_row
LEFT JOIN component_core_counts ccc ON crm.component_name = ccc.component_name
WHERE crm.component_name IN ('df-engine') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
WHERE crm.component_name IN ('df-engine', 'go-collector') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')

UNION ALL

SELECT 'ram_mib_avg' AS name, 'MiB' AS unit, avg_value / 1024 / 1024 AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - RAM (MiB)' AS extra
FROM component_resource_metrics
CROSS JOIN metadata_row
WHERE component_name IN ('df-engine') AND metric_name IN ('container.memory.usage', 'process.memory.usage')
WHERE component_name IN ('df-engine', 'go-collector') AND metric_name IN ('container.memory.usage', 'process.memory.usage')

UNION ALL

SELECT 'ram_mib_max' AS name, 'MiB' AS unit, max_value / 1024 / 1024 AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - RAM (MiB)' AS extra
FROM component_resource_metrics
CROSS JOIN metadata_row
WHERE component_name IN ('df-engine') AND metric_name IN ('container.memory.usage', 'process.memory.usage')
WHERE component_name IN ('df-engine', 'go-collector') AND metric_name IN ('container.memory.usage', 'process.memory.usage')

UNION ALL

Expand Down Expand Up @@ -327,15 +327,15 @@ queries:
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - Network Utilization' AS extra
FROM container_network_rates
CROSS JOIN metadata_row
WHERE metric_name = 'container.network.tx' AND component_name IN ('df-engine')
WHERE metric_name = 'container.network.tx' AND component_name IN ('df-engine', 'go-collector')

UNION ALL

SELECT 'network_rx_bytes_rate_avg' AS name, 'bytes/sec' AS unit, average_rate AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - Network Utilization' AS extra
FROM container_network_rates
CROSS JOIN metadata_row
WHERE metric_name = 'container.network.rx' AND component_name IN ('df-engine');
WHERE metric_name = 'container.network.rx' AND component_name IN ('df-engine', 'go-collector');

- name: Dashboard time-series data
sql: |
Expand All @@ -349,7 +349,7 @@ queries:
CROSS JOIN observation_window ow
LEFT JOIN component_core_counts ccc ON cr.component_name = ccc.component_name
WHERE cr.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
AND cr.component_name IN ('df-engine')
AND cr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -361,7 +361,7 @@ queries:
FROM component_resource_with_values cr
CROSS JOIN observation_window ow
WHERE cr.metric_name IN ('container.memory.usage', 'process.memory.usage')
AND cr.component_name IN ('df-engine')
AND cr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -374,7 +374,7 @@ queries:
JOIN observation_window ow ON nr.timestamp BETWEEN ow.start_ts AND ow.stop_ts
WHERE nr.rate IS NOT NULL
AND nr.metric_name = 'container.network.tx'
AND nr.component_name IN ('df-engine')
AND nr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -387,7 +387,7 @@ queries:
JOIN observation_window ow ON nr.timestamp BETWEEN ow.start_ts AND ow.stop_ts
WHERE nr.rate IS NOT NULL
AND nr.metric_name = 'container.network.rx'
AND nr.component_name IN ('df-engine')
AND nr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand Down
20 changes: 10 additions & 10 deletions tools/pipeline_perf_test/test_suites/comparison_dashboard/reports/report_traces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ queries:
FROM component_resource_metrics crm
CROSS JOIN metadata_row
LEFT JOIN component_core_counts ccc ON crm.component_name = ccc.component_name
WHERE crm.component_name IN ('df-engine') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
WHERE crm.component_name IN ('df-engine', 'go-collector') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')

UNION ALL

Expand All @@ -279,23 +279,23 @@ queries:
FROM component_resource_metrics crm
CROSS JOIN metadata_row
LEFT JOIN component_core_counts ccc ON crm.component_name = ccc.component_name
WHERE crm.component_name IN ('df-engine') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
WHERE crm.component_name IN ('df-engine', 'go-collector') AND crm.metric_name IN ('container.cpu.usage', 'process.cpu.usage')

UNION ALL

SELECT 'ram_mib_avg' AS name, 'MiB' AS unit, avg_value / 1024 / 1024 AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - RAM (MiB)' AS extra
FROM component_resource_metrics
CROSS JOIN metadata_row
WHERE component_name IN ('df-engine') AND metric_name IN ('container.memory.usage', 'process.memory.usage')
WHERE component_name IN ('df-engine', 'go-collector') AND metric_name IN ('container.memory.usage', 'process.memory.usage')

UNION ALL

SELECT 'ram_mib_max' AS name, 'MiB' AS unit, max_value / 1024 / 1024 AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - RAM (MiB)' AS extra
FROM component_resource_metrics
CROSS JOIN metadata_row
WHERE component_name IN ('df-engine') AND metric_name IN ('container.memory.usage', 'process.memory.usage')
WHERE component_name IN ('df-engine', 'go-collector') AND metric_name IN ('container.memory.usage', 'process.memory.usage')

UNION ALL

Expand Down Expand Up @@ -327,15 +327,15 @@ queries:
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - Network Utilization' AS extra
FROM container_network_rates
CROSS JOIN metadata_row
WHERE metric_name = 'container.network.tx' AND component_name IN ('df-engine')
WHERE metric_name = 'container.network.tx' AND component_name IN ('df-engine', 'go-collector')

UNION ALL

SELECT 'network_rx_bytes_rate_avg' AS name, 'bytes/sec' AS unit, average_rate AS value,
metadata_row."test.suite" || '/' || metadata_row."test.name" || ' - Network Utilization' AS extra
FROM container_network_rates
CROSS JOIN metadata_row
WHERE metric_name = 'container.network.rx' AND component_name IN ('df-engine');
WHERE metric_name = 'container.network.rx' AND component_name IN ('df-engine', 'go-collector');

- name: Dashboard time-series data
sql: |
Expand All @@ -349,7 +349,7 @@ queries:
CROSS JOIN observation_window ow
LEFT JOIN component_core_counts ccc ON cr.component_name = ccc.component_name
WHERE cr.metric_name IN ('container.cpu.usage', 'process.cpu.usage')
AND cr.component_name IN ('df-engine')
AND cr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -361,7 +361,7 @@ queries:
FROM component_resource_with_values cr
CROSS JOIN observation_window ow
WHERE cr.metric_name IN ('container.memory.usage', 'process.memory.usage')
AND cr.component_name IN ('df-engine')
AND cr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -374,7 +374,7 @@ queries:
JOIN observation_window ow ON nr.timestamp BETWEEN ow.start_ts AND ow.stop_ts
WHERE nr.rate IS NOT NULL
AND nr.metric_name = 'container.network.tx'
AND nr.component_name IN ('df-engine')
AND nr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand All @@ -387,7 +387,7 @@ queries:
JOIN observation_window ow ON nr.timestamp BETWEEN ow.start_ts AND ow.stop_ts
WHERE nr.rate IS NOT NULL
AND nr.metric_name = 'container.network.rx'
AND nr.component_name IN ('df-engine')
AND nr.component_name IN ('df-engine', 'go-collector')

UNION ALL

Expand Down
Loading