-
Notifications
You must be signed in to change notification settings - Fork 61
Upgrade arrow to improve zstd payload compression performance in OTAP Exporter #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
- Coverage 83.88% 83.83% -0.06%
==========================================
Files 398 398
Lines 108990 108990
==========================================
- Hits 91428 91371 -57
- Misses 17028 17085 +57
Partials 534 534
🚀 New features to boost your workflow:
|
|
Tested perf manually:
load gen (3 cores) settings:
default_pipeline_ctrl_msg_channel_size: 100
default_node_ctrl_msg_channel_size: 100
default_pdata_channel_size: 100
nodes:
receiver:
kind: receiver
plugin_urn: "urn:otel:otap:fake_data_generator:receiver"
out_ports:
out_port:
destinations:
- exporter
dispatch_strategy: round_robin
config:
traffic_config:
# max_signal_count: 1000
max_batch_size: 1000
signals_per_second: 50000
log_weight: 100
registry_path: https://github.com/open-telemetry/semantic-conventions.git[model]
exporter:
kind: exporter
plugin_urn: "urn:otel:otap:exporter"
config:
grpc_endpoint: "http://127.0.0.1:4317"
compression_method: zstd
arrow:
payload_compression: nonesystem under test (1 core) settings:
default_pipeline_ctrl_msg_channel_size: 100
default_node_ctrl_msg_channel_size: 100
default_pdata_channel_size: 100
nodes:
receiver:
kind: receiver
plugin_urn: "urn:otel:otap:receiver"
out_ports:
out_port:
destinations:
- exporter
dispatch_strategy: round_robin
config:
listening_addr: "127.0.0.1:4317"
response_stream_channel_size: 256
compression_method: zstd
exporter:
kind: exporter
plugin_urn: "urn:otel:otap:exporter"
config:
grpc_endpoint: "http://127.0.0.1:4318"
compression_method: zstd
arrow:
payload_compression: zstd |
lquerel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for the improvement you did in the Arrow crate! |
c3e6f34
Closes #1129
arrow-rs 57.0 has an improvement for the performance of zstd IPC compression apache/arrow-rs#8405