Unify internal observability documentation - 2 of 3 #4322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Just getting started. I'll tag everyone when it's ready for review. Thanks! |
tiffany76
requested review from
a team and
TylerHelmuth
and removed request for
a team
Member
Author
|
Hi @svrnm , @theletterf, @mx-psi, @codeboten, This PR is ready for review. I'm also adding a few in-line comments and questions for the group. Thanks! |
tiffany76
commented
May 2, 2024
tiffany76
commented
May 2, 2024
tiffany76
commented
May 2, 2024
tiffany76
commented
May 2, 2024
Member
|
This looks really good, I answered some of your questions. Thanks! |
theletterf
approved these changes
May 3, 2024
Member
theletterf
left a comment
theletterf
left a comment
There was a problem hiding this comment.
Lots of good stuff in here. Thanks so much, @tiffany76 !
mx-psi
reviewed
May 3, 2024
tiffany76
commented
May 6, 2024
chalin
reviewed
May 7, 2024
chalin
reviewed
May 7, 2024
Contributor
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Nice work. See inline for questions, remarks, and suggestions. Thanks.
chalin
reviewed
May 8, 2024
Member
Author
|
I've addressed all the comments and suggestions made so far. If anyone would like to take another look, now's your chance. Thanks! |
chalin
reviewed
May 9, 2024
Contributor
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Looking good! A few more comments, see inline. Thx
chalin
reviewed
May 9, 2024
Co-authored-by: Patrice Chalin <[email protected]>
mx-psi
reviewed
May 10, 2024
chalin
reviewed
May 10, 2024
chalin
reviewed
May 10, 2024
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
mx-psi
approved these changes
May 15, 2024
Contributor
|
Good to merge here @svrnm? |
Member
|
Yes! |
Contributor
|
Great work @tiffany76 et all! 🙌🏻 🎉 |
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Jun 28, 2024
#### Description Now that [4246](open-telemetry/opentelemetry.io#4246), [4322](open-telemetry/opentelemetry.io#4322), and [4529](open-telemetry/opentelemetry.io#4529) have been merged, and the new [Internal telemetry](https://opentelemetry.io/docs/collector/internal-telemetry/) and [Troubleshooting](https://opentelemetry.io/docs/collector/troubleshooting/) pages are live, it's time to clean up the underlying Collector repo docs so that the website is the single source of truth. I've deleted any content that was moved to the website, and linked to the relevant sections where possible. I've consolidated what content remains in the observability.md file and left troubleshooting.md and monitoring.md as stubs that point to the website. I also searched the Collector repo for cross-references to these files and adjusted links where appropriate. ~~Note that this PR is blocked by [4731](open-telemetry/opentelemetry.io#4731 EDIT: #4731 is merged and no longer a blocker. <!-- Issue number if applicable --> #### Link to tracking issue Fixes #8886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second of three. Together they will create a new internal observability document on opentelemetry.io, combining and migrating multiple markdown files from the Collector repo. This PR covers the section on types of internal observability.
Link to tracking issue: open-telemetry/opentelemetry-collector#8886.
Also fixes #4278.
Also relates to:
Follow up PR (3 of 3) will be created once this one is merged.
PREVIEW: https://deploy-preview-4322--opentelemetry.netlify.app/docs/collector/internal-telemetry/