Add the Context notion.#424
Merged
bogdandrutu merged 85 commits intoopen-telemetry:masterfrom Feb 12, 2020
Merged
Conversation
carlosalberto
requested review from
AloisReitbauer,
SergeyKanzhelev,
bogdandrutu,
c24t,
iredelmeier,
jmacd,
reyang,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
Oberon00
reviewed
Jan 27, 2020
Oberon00
reviewed
Jan 27, 2020
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>
Member
|
Last comment that needs to be addressed is about |
jkwatson
reviewed
Feb 11, 2020
jkwatson
reviewed
Feb 11, 2020
jkwatson
reviewed
Feb 11, 2020
jkwatson
reviewed
Feb 11, 2020
jkwatson
reviewed
Feb 11, 2020
jkwatson
reviewed
Feb 11, 2020
dyladan
reviewed
Feb 11, 2020
jkwatson
reviewed
Feb 11, 2020
jkwatson
reviewed
Feb 11, 2020
Co-Authored-By: John Watson <jkwatson@gmail.com>
Co-Authored-By: John Watson <jkwatson@gmail.com>
Co-Authored-By: John Watson <jkwatson@gmail.com>
Co-Authored-By: John Watson <jkwatson@gmail.com>
Co-Authored-By: John Watson <jkwatson@gmail.com>
Co-Authored-By: John Watson <jkwatson@gmail.com>
Co-Authored-By: John Watson <jkwatson@gmail.com>
Co-Authored-By: John Watson <jkwatson@gmail.com>
codeboten
approved these changes
Feb 12, 2020
bogdandrutu
approved these changes
Feb 12, 2020
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Initial context integration. * Update api-propagators.md * Remove the mention of binary propagators. * Mention that the tracing's propagation must happen internally. * Make context -> Context. * Rename api-context.md to context.md * Remove the notion of key. * Add a note on Context being a SDK API. * Note on the optional global operations. * Clean up pass. * Remove context-prop from the *tracing* index. * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * First clean up pass over Context. * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Overview and layout updates. * Make the MD linter happy (long lines though). * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Use MUST/SHOULD for clarifying propagators expectations. * Move the IsRemote deserialization note to the Extraction section. * Improve wording for Context handling in Extraction. * Clarify the protected global methods in context.md * Remove the extra explanation of Context in overview.md * Improve the wording for set/remove values in context.md * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Fix style? * Clarify the Context usage in Extract. * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Clarify IsRemote on Extract. * More style changes. * OTel MUST provide Context impl if none exists. * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Reword the optionality of Context in propagators. * Clarify again the expected usage for implicit `Context`. * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Be more strict on the Context parameters. * Clarify that SDK/OTel instrumentation only SHOULD use global Context. * Mention that Context will be used through concerns APIs. * Update specification/api-propagators.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Update specification/api-propagators.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * We do not use the Required word anymore. * Do not require extract to set null/empty upon errors. * Better wording for failed extraction values. * Update specification/context.md Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Clarify ONCE that Context is immutable. * Use "derived" instead of "child" for Context-Context relationships. * Remove a misleading line. * Mention tracing uses Context specifially. * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Clarify that Context keeps the untouched original values. * Clarify a new Context is created only for write operations. * Misc fixes. * Set current Context should return a handle. * Note on global Context operations. * Remove the Remove operation on Context. * Clarify the usage of cross-cutting concern APIs. * Restore "Create a key" section. * Minor fix to a previous commit. * Add a detach operation. * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/api-tracing.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Use value instead of object for Token. Co-authored-by: Christian Neumüller <christian+github@neumueller.me> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: John Watson <jkwatson@gmail.com> Co-authored-by: Bogdan Drutu <lazy@splunk.com>
This was referenced Feb 26, 2020
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Initial context integration. * Update api-propagators.md * Remove the mention of binary propagators. * Mention that the tracing's propagation must happen internally. * Make context -> Context. * Rename api-context.md to context.md * Remove the notion of key. * Add a note on Context being a SDK API. * Note on the optional global operations. * Clean up pass. * Remove context-prop from the *tracing* index. * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * First clean up pass over Context. * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Overview and layout updates. * Make the MD linter happy (long lines though). * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/context.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Use MUST/SHOULD for clarifying propagators expectations. * Move the IsRemote deserialization note to the Extraction section. * Improve wording for Context handling in Extraction. * Clarify the protected global methods in context.md * Remove the extra explanation of Context in overview.md * Improve the wording for set/remove values in context.md * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update specification/api-propagators.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Fix style? * Clarify the Context usage in Extract. * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Clarify IsRemote on Extract. * More style changes. * OTel MUST provide Context impl if none exists. * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Reword the optionality of Context in propagators. * Clarify again the expected usage for implicit `Context`. * Update specification/context.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Be more strict on the Context parameters. * Clarify that SDK/OTel instrumentation only SHOULD use global Context. * Mention that Context will be used through concerns APIs. * Update specification/api-propagators.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * Update specification/api-propagators.md Co-Authored-By: Tyler Yahn <MrAlias@users.noreply.github.com> * We do not use the Required word anymore. * Do not require extract to set null/empty upon errors. * Better wording for failed extraction values. * Update specification/context.md Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Clarify ONCE that Context is immutable. * Use "derived" instead of "child" for Context-Context relationships. * Remove a misleading line. * Mention tracing uses Context specifially. * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Clarify that Context keeps the untouched original values. * Clarify a new Context is created only for write operations. * Misc fixes. * Set current Context should return a handle. * Note on global Context operations. * Remove the Remove operation on Context. * Clarify the usage of cross-cutting concern APIs. * Restore "Create a key" section. * Minor fix to a previous commit. * Add a detach operation. * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/api-propagators.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/context.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Update specification/api-tracing.md Co-Authored-By: John Watson <jkwatson@gmail.com> * Use value instead of object for Token. Co-authored-by: Christian Neumüller <christian+github@neumueller.me> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: John Watson <jkwatson@gmail.com> Co-authored-by: Bogdan Drutu <lazy@splunk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to include some of the changes of OTEP 66, by making the Specification
Contextaware.Summary of changes:
Contextmechanism section to describe what is expected in all languages overall. This is mostly described as a SDK API, in order to signal that users instrumenting their application shouldn't use it directly.Propagatorsto make them directly consumeContext.Tracer's currentSpanhandling as this now belongs toContext(changes this part from MUST to SHOULD).Binarysupport for now.Binaryneeds to be updated to play along well, and it's still a work in progress anyway. The plan is to add it again in the near future, once it has been prototyped/tested.I'm specially interested in feedback regarding 1), so feel free to provide insights ;)