Skip to content

Conversation

@Oberon00
Copy link
Member

These places were removed when #3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.

Editorial change, no CHANGELOG or issue.

@Oberon00 Oberon00 added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. labels Mar 21, 2023
@Oberon00 Oberon00 requested review from a team March 21, 2023 14:42
These places were removed when open-telemetry#3188 in its original form removed
faas.id without replacement and weren't added back after changing
it to introduce cloud.resource_id instead.
@Oberon00 Oberon00 force-pushed the feature/faas-cloud-id-ref branch from 616bd97 to 36f468c Compare March 21, 2023 14:45
@Oberon00
Copy link
Member Author

CC @tylerbenson @lmolkova (as you were involved in #3188)

@arminru arminru requested review from a team, lmolkova and tylerbenson March 28, 2023 10:16
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 5, 2023
@carlosalberto carlosalberto merged commit 0f6fbe5 into open-telemetry:main Apr 11, 2023
@Oberon00 Oberon00 deleted the feature/faas-cloud-id-ref branch April 11, 2023 13:54
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…etry#3329)

These places were removed when open-telemetry#3188 in its original form removed
faas.id without replacement and weren't added back after changing it to
introduce cloud.resource_id instead.

Editorial change, no CHANGELOG or issue.
schmikei pushed a commit to schmikei/opentelemetry-specification that referenced this pull request Apr 17, 2025
…etry#3329)

These places were removed when open-telemetry#3188 in its original form removed
faas.id without replacement and weren't added back after changing it to
introduce cloud.resource_id instead.

Editorial change, no CHANGELOG or issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:semantic-conventions Related to semantic conventions editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants