-
Notifications
You must be signed in to change notification settings - Fork 935
Refactor messaging attributes and specify per-message attributes #2957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor messaging attributes and specify per-message attributes #2957
Conversation
bb6e939 to
57ec5e8
Compare
d80d135 to
f4811cb
Compare
joaopgrassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass on the yaml file, looking great! I will take a look at the rest later and submit a new review then.
f4811cb to
9b249a9
Compare
joaopgrassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to do another pass before the meeting, but only got around it today.
|
@lmolkova Can you please rebase? This should fix the failing markdown-link build job. |
307ede1 to
b896623
Compare
…orresponding groups
Co-authored-by: Johannes Tax <[email protected]> Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
7fe171c to
084d6db
Compare
The final round of #2763
Changes
Messaging instrumentation SIG is working on spec changes and this change is one of the first steps to bring the consensus we reached in SIG to the spec.
This change introduces different namespace for different kinds of attributes:
messaging.messagefor message properties (e.g. message id or payload size)messaging.destinationfor producers to describe publish operations (e.g. queue name)messaging.sourcefor consumers to describe receive/deliver/process operations (e.g. queue name)messaging.batchfor to describe batch properties (e.g. message count)messaging.consumerfor to describe consumer properties (e.g. consumer id)It also introduces guidance for specific systems on namespaces.
Here's the list of breaking changes (attribute renames):
messaging.protocol:net.app.protocol.namemessaging.protocol_version: net.app.protocol.versionmessaging.destination: messaging.destination.namemessaging.temp_destination: messaging.destination.temporarymessaging.destination_kind: messaging.destination.kindmessaging.message_id:messaging.message.idmessaging.conversation_id:messaging.message.conversation_idmessaging.message_payload_size_bytes:messaging.message.payload_size_bytesmessaging.message_payload_compressed_size_bytes:messaging.message.payload_compressed_size_bytesmessaging.rabbitmq.routing_key:messaging.rabbitmq.message.routing_keymessaging.kafka.message_key:messaging.kafka.message.keymessaging.kafka.partition:messaging.kafka.message.partitionmessaging.kafka.tombstone:messaging.kafka.message.tombstonemessaging.rocketmq.message_type:messaging.rocketmq.message.typemessaging.rocketmq.message_tag:messaging.rocketmq.message.tagmessaging.rocketmq.message_keys:messaging.rocketmq.message.keysIt also adds the
messaging.batch.message_countattribute which intends to:Related OTEP(s) #