Skip to content

Update default OTLP port #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2020
Merged

Update default OTLP port #388

merged 2 commits into from
Dec 17, 2020

Conversation

@drexler
Copy link
Contributor

@drexler drexler commented Dec 16, 2020

Fixes #363

@drexler drexler requested a review from a team December 16, 2020 21:36
@drexler drexler changed the title feat: update default OTLP port Update default OTLP port Dec 16, 2020
drexler
drexler commented Dec 16, 2020
View reviewed changes
opentelemetry-otlp/README.md

```shell
$ docker run -p 55680:55680 otel/opentelemetry-collector-dev:latest
$ docker run -p 4317:4317 otel/opentelemetry-collector-dev:latest
Copy link
Contributor Author

@drexler drexler Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The support for this port has been released in the Docker image: https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.16.0

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #388 (6258778) into master (6d44f23) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   49.42%   49.40%   -0.02%     
==========================================
  Files          66       66              
  Lines        5356     5356              
==========================================
- Hits         2647     2646       -1     
- Misses       2709     2710       +1
Impacted Files Coverage Δ
opentelemetry-otlp/src/span.rs 2.67% <0.00%> (ø)
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.76% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d44f23...6258778. Read the comment docs.

jtescher
jtescher approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jtescher jtescher merged commit f5b1900 into open-telemetry:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jtescher jtescher jtescher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update default otlp port number

2 participants

@drexler @jtescher