-
Notifications
You must be signed in to change notification settings - Fork 277
Add API ref and Examples to docs sidebar #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API ref and Examples to docs sidebar #1394
Conversation
plantfansam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have you checked that this builds and renders properly?
The netlify-cli can be finicky and flakey but it is getting much better. Redirect rules work most of the time for me now (consider running |
|
@arielvalentin yes! Heh. In fact, most languages are moved back to the website repo. I believe that part of the reason for the split was because it was earlier days where literally nothing was stable and even the tracing SDKs were changing every day. Now that most languages are GA for tracing and some degree of stable for metrics, there's less churn in defining how you even use an SDK, and a lot more an adding scenarios, commentary, and general docs completeness. I was planning on bringing this to the Ruby SIG next week or the week after, but if it's acceptable to just do the move now we can definitely accommodate. There's some more things to consider that may still be good to chat about (e.g., how to eventually roll out metrics docs, where API docs should live, something something logs signal, etc.) - more than happy to chat about it. |
|
Thank you very much for your help here with maintaining docs!
I am in favor of moving the docs! My one request is that @open-telemetry/ruby-approvers and @open-telemetry/ruby-contrib-approvers be granted collaborator access and added to |
Wonderful!
Yes, of course. I'll create an issue to track the necessary work, as we did for the other language SIGs. @arielvalentin - Can we get this PR merged soon (before the move)? |
|
@chalin absolutely! Sadly I am not a maintainer in this repo... |

This adds the Ruby version of open-telemetry/opentelemetry.io#1808