fix: Allow HTTP method to be passed as string #1159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrisaro
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
mwear and
robertlaurin
as code owners
|
|
Contributor
|
Thanks so much for the PR @nickrisaro! At first glance, I believe that this should be addressed by @hosamaly's work in #1147, which will create a lookup hash with both string and symbol keys. |
Author
|
Thanks for the comment @plantfansam! I didn't find that PR yesterday when looking for this. I agree with you, @hosamaly's solution is better than mine. I'll close this PR in favor of #1147 |
Contributor
|
Thanks for your contribution @nickrisaro 😄! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Excon docs is possible to set the HTTP Method with a string but when using excon instrumentation this fails with the following error
[2022-03-22T17:31:14.333447 #85108] ERROR -- : OpenTelemetry error: invalid span attribute value type NilClass for key 'http.method' on span 'HTTP 'On this PR we add a test case for the described scenario and a fix to use the string if no symbol was provided.
Fixes #1158