-
Notifications
You must be signed in to change notification settings - Fork 917
Added a warning log when the existing TracerProvider and MeterProvider are overridden #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lzchen
merged 7 commits into
open-telemetry:master
from
bitspradp:bitspradp/warning-log
Jun 30, 2020
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e43a899
Added a warning log when the existing TracerProvider and MeterProvide…
bitspradp 8755f34
Fixing mypy issues by adding #type ignore
bitspradp 452250c
Fixing black indentation with extra newline
bitspradp 11fda16
Fixing multi line string by enclosing it in braces and also added the…
bitspradp 2129555
Merge branch 'master' into bitspradp/warning-log
4374387
Merge branch 'master' into bitspradp/warning-log
toumorokoshi 2e27ae2
Merge branch 'master' into bitspradp/warning-log
toumorokoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # type:ignore | ||
| import unittest | ||
| from logging import WARNING | ||
|
|
||
| from opentelemetry import metrics | ||
| from opentelemetry.sdk.metrics import MeterProvider | ||
|
|
||
|
|
||
| class TestGlobals(unittest.TestCase): | ||
| def test_meter_provider_override_warning(self): | ||
| """metrics.set_meter_provider should throw a warning when overridden""" | ||
| metrics.set_meter_provider(MeterProvider()) | ||
| with self.assertLogs(level=WARNING) as test: | ||
| metrics.set_meter_provider(MeterProvider()) | ||
| self.assertEqual( | ||
| test.output, | ||
| [ | ||
| "WARNING:opentelemetry.metrics:Overriding current " | ||
| "MeterProvider" | ||
| ], | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.