Fix Flaky opentelemetry-sdk tests - #5415
Open
Eason09053360 wants to merge 3 commits into
Open
Conversation
|
|
Eason09053360
force-pushed
the
fix-flaky-opentelemetry-sdk-tests
branch
from
July 14, 2026 10:06
98e1d1e to
28ca418
Compare
Eason09053360
marked this pull request as ready for review
July 14, 2026 11:39
Eason09053360
marked this pull request as draft
July 14, 2026 11:53
Eason09053360
force-pushed
the
fix-flaky-opentelemetry-sdk-tests
branch
from
July 14, 2026 12:08
28ca418 to
e3e2770
Compare
Eason09053360
marked this pull request as ready for review
July 14, 2026 12:09
Contributor
Author
|
cc @xrmx |
Eason09053360
force-pushed
the
fix-flaky-opentelemetry-sdk-tests
branch
from
July 18, 2026 05:55
e3e2770 to
e00e176
Compare
Eason09053360
added a commit
to Eason09053360/opentelemetry-python
that referenced
this pull request
Jul 19, 2026
Eason09053360
force-pushed
the
fix-flaky-opentelemetry-sdk-tests
branch
from
July 24, 2026 08:40
8d1e471 to
6f7217a
Compare
lzchen
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
ConcurrentMultiSpanProcessor.shutdown()before the mock call countassertions in
test_force_flush_late_by_timeout.Waiting for shutdown before checking the call counts ensures that the
background work has completed and prevents the test from failing due to
thread scheduling.
Fixes #5393
Type of change
How Has This Been Tested?
The affected test was run using the Python 3.12 OpenTelemetry SDK tox
environment.
uv run tox -e py312-test-opentelemetry-sdk -- opentelemetry-sdk/tests/trace/test_span_processor.py -k test_force_flush_late_by_timeout -qResult: 4 passed, 850 deselected.
Does This PR Require a Contrib Repo Change?
Checklist: