fix(api): use provided carriers for normalized EnvironmentGetter lookups - #5222
Closed
pellared wants to merge 3 commits into
Closed
fix(api): use provided carriers for normalized EnvironmentGetter lookups#5222pellared wants to merge 3 commits into
pellared wants to merge 3 commits into
Conversation
Assisted-by: ChatGPT 5
pellared
changed the title
EnvironmentGetter lookups
pellared
changed the title
EnvironmentGetter lookups
pellared
changed the title
Assisted-by: ChatGPT 5
Member
Author
|
@xrmx PTAL |
Member
Author
|
Closing per #5221 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #5221 (comment)
Normalize explicit
EnvironmentGettercarrier keys during lookup and key enumeration.The getter still uses the environment snapshot captured at initialization when callers pass an empty carrier, preserving the behavior added in #5119.
Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: