Skip to content

Conversation

@c24t
Copy link
Member

@c24t c24t commented Mar 14, 2020

Follow up to #471 to add generated docs.

_Users_libc_src_opentelemetry-python_docs__build_html_api_correlationcontext html(iPad Pro)

_Users_libc_src_opentelemetry-python_docs__build_html_api_correlationcontext propagation html(iPad Pro)

@c24t c24t requested a review from a team March 14, 2020 23:48
@mauriciovasquezbernal
Copy link
Member

Since #471 isn't merged yet, woulnd't it make sense if @codeboten cherry-picks a8d71db & 8409e3a there so we have everything in a single place?

@c24t
Copy link
Member Author

c24t commented Mar 16, 2020

Since #471 isn't merged yet, woulnd't it make sense if @codeboten cherry-picks a8d71db & 8409e3a there so we have everything in a single place?

That would have been fine, but we can merge them separately now that #471 was merged.

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of the docs.

@mauriciovasquezbernal mauriciovasquezbernal added doc Documentation-related api Affects the API package. labels Mar 17, 2020
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c24t c24t merged commit b615804 into open-telemetry:master Mar 18, 2020
@c24t c24t deleted the correlationcontext-docs branch March 18, 2020 20:25
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
* chore: update metrics README

* chore: add npm badge

* chore: add todo

* chore: add WIP measures

* chore: minor

* chore: update metrics README

* fix: review comment

* fix: review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Affects the API package. doc Documentation-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants