Skip to content

Remove references to 3.7 #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Remove references to 3.7 #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
995ee8d
Remove references to 3.7
ocelotl Feb 12, 2024
c3e80d3
Merge branch 'main' into issue_2171
ocelotl Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions instrumentation/opentelemetry-instrumentation-urllib/tests/test_metrics_instrumentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@


from platform import python_implementation
from sys import version_info
from timeit import default_timer
from urllib import request
from urllib.parse import urlencode
Expand Down Expand Up @@ -189,8 +188,7 @@ def test_basic_metric_request_not_empty(self):
)

@mark.skipif(
python_implementation() == "PyPy" or version_info.minor == 7,
reason="Fails randomly in 3.7 and pypy",
python_implementation() == "PyPy", reason="Fails randomly in pypy"
)
def test_metric_uninstrument(self):
with request.urlopen(self.URL):
Expand Down
1 change: 0 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ envlist =
py3{8,9,10,11}-test-instrumentation-grpc

; opentelemetry-instrumentation-sqlalchemy
py3{7}-test-instrumentation-sqlalchemy-{11}
py3{8,9,10,11}-test-instrumentation-sqlalchemy-{14}
pypy3-test-instrumentation-sqlalchemy-{11,14}

Expand Down