Drop PHP 7.4 support by brettmc · Pull Request #1244 · open-telemetry/opentelemetry-php

brettmc · 2024-02-29T04:41:54Z

update composer.json minimums, and run rector over the code to update what it can. changed some static analysis config to fix some rector-induced failures.
adding some union type-hints which rector didn't, and remove the corresponding @param phpdoc
update typehint for metric aggregation, and note a todo for 8.1+ to convert to an enum

To do:

fix TypeError: WeakMap key must be an object test failures with batch exporter self-diagnostics
remove 7.4 from opentelemetry-php/gh-workflows/.github/workflows/validate-packages.yml

update composer.json minimums, and run rector over the code to update what it can. changed some static analysis config to fix some rector-induced failures.

codecov · 2024-02-29T04:43:23Z

Codecov Report

Attention: Patch coverage is 81.91126% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 84.62%. Comparing base (cc56628) to head (22a20e1).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1244      +/-   ##
============================================
+ Coverage     83.08%   84.62%   +1.53%     
+ Complexity     2274     2136     -138     
============================================
  Files           285      284       -1     
  Lines          6456     6054     -402     
============================================
- Hits           5364     5123     -241     
+ Misses         1092      931     -161

Flag	Coverage Δ
7.4	`?`
8.0	`84.57% <81.91%> (+1.58%)`	⬆️
8.1	`84.60% <81.91%> (+1.45%)`	⬆️
8.2	`84.60% <81.91%> (+1.45%)`	⬆️
8.3	`84.60% <81.91%> (+1.45%)`	⬆️
8.4	`84.60% <81.91%> (+1.45%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/API/Baggage/Baggage.php	`82.14% <100.00%> (-0.62%)`	⬇️
src/API/Baggage/Propagation/Parser.php	`100.00% <100.00%> (ø)`
src/API/Behavior/Internal/LogWriterFactory.php	`78.94% <ø> (ø)`
src/API/Globals.php	`93.54% <ø> (-0.74%)`	⬇️
src/API/Instrumentation/CachedInstrumentation.php	`100.00% <100.00%> (ø)`
src/API/Instrumentation/InstrumentationTrait.php	`95.23% <ø> (ø)`
src/API/Logs/EventLogger.php	`100.00% <100.00%> (ø)`
src/API/Logs/LogRecord.php	`100.00% <100.00%> (ø)`
src/API/Logs/Map/Psr3.php	`100.00% <100.00%> (ø)`
src/API/Metrics/Noop/NoopMeterProvider.php	`0.00% <ø> (ø)`
... and 160 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc56628...22a20e1. Read the comment docs.

submitted a PR upstream to fix phan stubs

brettmc · 2024-02-29T13:22:00Z

The WeakMap issue I was hitting is actually a bug fixed in 8.0.22, 8.1.9 and 8.2.0 - found and fixed by otel's own Nevay. I just hadn't updated my 8.0 build environment for a really long time.

agoallikmaa

I suppose symfony/polyfill-php80 dependency can also be removed now?

Nevay

Some more methods where union types can be added:

SpanBuilderInterface::setParent() and ::setAttribute()
MeterInterface $advisory parameter
ObserverInterface::observe()
LogRecord::setAttribute()

We can use WeakMap directly now and can remove:

OpenTelemetry\API\Instrumentation\CachedInstrumentation::createWeakMap()
OpenTelemetry\SDK\Common\Util\WeakMap

Nevay · 2024-03-01T18:31:20Z

src/API/Baggage/Entry.php

-        $value,
-        MetadataInterface $metadata
+        private mixed $value,
+        private MetadataInterface $metadata


Suggested change

private MetadataInterface $metadata

private MetadataInterface $metadata,

Should add trailing comma to changed constructors to reduce diff if we add more parameters.

added a php-cs-fixer rule to apply this to all multiline function declarations

src/Context/Propagation/MultiTextMapPropagator.php

src/Contrib/Otlp/ProtobufSerializer.php

upgrade php-cs-fixer, and apply a new rule for multiline comments

ChrisLightfootWild

Nice 🧹 💪

src/Context/ContextKey.php

brettmc added 2 commits February 29, 2024 13:25

drop php 7.4 support

8342aba

update composer.json minimums, and run rector over the code to update what it can. changed some static analysis config to fix some rector-induced failures.

adding union typehints

71dc03a

brettmc added 3 commits February 29, 2024 18:43

reformat constructor property promotions

be34c22

updating/removing phpdoc

d81115a

suppress protobuf extension complaint

0f1d747

submitted a PR upstream to fix phan stubs

brettmc added 2 commits March 1, 2024 14:01

Merge branch 'main' into drop-74-support

5f4b54b

don't validate packages against 7.4

3c60ab0

brettmc force-pushed the drop-74-support branch from df9dca9 to 3c60ab0 Compare March 1, 2024 04:05

brettmc marked this pull request as ready for review March 1, 2024 04:38

brettmc requested a review from a team March 1, 2024 04:38

agoallikmaa approved these changes Mar 1, 2024

View reviewed changes

Nevay reviewed Mar 1, 2024

View reviewed changes

brettmc added 7 commits March 2, 2024 07:39

remove php8 polyfill

c5caa97

fix readonly comments

f13bb60

apply trailing commas to multiline fixer

5c8c005

upgrade php-cs-fixer, and apply a new rule for multiline comments

remove unreachable default match arms for protobuf serializer

ee35bde

adding more union types to vars

14df902

use weakmap directly

b81438c

remove handling for not-supported WeakMap

7efcff0

ChrisLightfootWild approved these changes Mar 3, 2024

View reviewed changes

src/Context/ContextKey.php Outdated Show resolved Hide resolved

spacing

22a20e1

brettmc added this to the 1.1.x milestone Mar 4, 2024

bobstrecansky approved these changes Mar 4, 2024

View reviewed changes

bobstrecansky merged commit f798bb6 into open-telemetry:main Mar 4, 2024

brettmc deleted the drop-74-support branch January 29, 2025 21:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Drop PHP 7.4 support#1244

Drop PHP 7.4 support#1244
bobstrecansky merged 15 commits intoopen-telemetry:mainfrom
brettmc:drop-74-support

brettmc commented Feb 29, 2024 •

edited

Loading

Uh oh!

codecov bot commented Feb 29, 2024 •

edited

Loading

Uh oh!

brettmc commented Feb 29, 2024 •

edited

Loading

Uh oh!

agoallikmaa left a comment

Uh oh!

Nevay left a comment

Uh oh!

Nevay Mar 1, 2024

Uh oh!

brettmc Mar 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ChrisLightfootWild left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	private MetadataInterface $metadata
	private MetadataInterface $metadata,

Comments

Conversation

brettmc commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brettmc commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agoallikmaa left a comment

Choose a reason for hiding this comment

Uh oh!

Nevay left a comment

Choose a reason for hiding this comment

Uh oh!

Nevay Mar 1, 2024

Choose a reason for hiding this comment

Uh oh!

brettmc Mar 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ChrisLightfootWild left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brettmc commented Feb 29, 2024 •

edited

Loading

codecov bot commented Feb 29, 2024 •

edited

Loading

brettmc commented Feb 29, 2024 •

edited

Loading

brettmc Mar 2, 2024 •

edited

Loading